Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 262658 - =media-sound/quodlibet-2.1 doesn't start if previously closed while hidden
Summary: =media-sound/quodlibet-2.1 doesn't start if previously closed while hidden
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Sound Team
URL: http://code.google.com/p/quodlibet/is...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-16 13:42 UTC by Justin Rittenhouse
Modified: 2009-07-19 15:21 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Rittenhouse 2009-03-16 13:42:11 UTC
If Quod Libet is closed while hidden/minimized to the tray, the next time it is run, it won't start.  This is avoided by changing "icon_window_visible = false" to true (under [plugins]) in the ~/.quodlibet/config file before starting the application.

Reproducible: Always

Steps to Reproduce:
1. Start Quod Libet.
2. Minimize to tray.
3. Close Quod Libet while minimized.
4. Start Quod Libet.

Actual Results:  
Quod Libet errors out.

Expected Results:  
Quod Libet should either start up minimized or reset the config setting to start unminimized.

Traceback (most recent call last):
  File "/usr/bin/quodlibet", line 274, in <module>
    main()
  File "/usr/bin/quodlibet", line 62, in main
    quodlibet.main(window)
  File "//usr/lib64/python2.5/site-packages/quodlibet/__init__.py", line 198, in main
    window.show()
TypeError: descriptor 'show' of 'gtk.Widget' object needs an argument
Comment 1 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2009-03-17 19:15:11 UTC
Please post your "emerge --info".
Comment 2 Justin Rittenhouse 2009-03-17 19:17:08 UTC
Portage 2.1.6.7 (default/linux/amd64/2008.0, gcc-4.1.2, glibc-2.8_p20080602-r1, 2.6.27-gentoo-r8 x86_64)
=================================================================
System uname: Linux-2.6.27-gentoo-r8-x86_64-Intel-R-_Core-TM-2_Duo_CPU_T9300_@_2.50GHz-with-glibc2.2.5
Timestamp of tree: Tue, 17 Mar 2009 07:45:02 +0000
app-shells/bash:     3.2_p39
dev-java/java-config: 1.3.7-r1, 2.1.6-r1
dev-lang/python:     2.4.4-r13, 2.5.2-r7
dev-python/pycrypto: 2.0.1-r6
dev-util/cmake:      2.6.3
sys-apps/baselayout: 1.12.11.1
sys-apps/sandbox:    1.2.18.1-r2
sys-devel/autoconf:  2.13, 2.63
sys-devel/automake:  1.5, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10.2
sys-devel/binutils:  2.18-r3
sys-devel/gcc-config: 1.4.0-r4
sys-devel/libtool:   1.5.26
virtual/os-headers:  2.6.27-r2
ACCEPT_KEYWORDS="amd64"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=nocona -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/revdep-rebuild /etc/terminfo /etc/udev/rules.d"
CXXFLAGS="-march=nocona -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
EMERGE_DEFAULT_OPTS="--keep-going"
FEATURES="distlocks fixpackages parallel-fetch protect-owned sandbox sfperms strict unmerge-orphans userfetch"
GENTOO_MIRRORS="ftp://ftp.ussg.iu.edu/pub/linux/gentoo http://mirror.mcs.anl.gov/pub/gentoo/ ftp://mirror.mcs.anl.gov/pub/gentoo/ http://lug.mtu.edu/gentoo/ ftp://lug.mtu.edu/gentoo/ "
LANG="en_US.UTF-8"
LC_ALL=""
LDFLAGS="-Wl,-O1"
LINGUAS="en_US en"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage/layman/sunrise /usr/local/portage"
SYNC="rsync://rsync.namerica.gentoo.org/gentoo-portage"
USE="X a52 acl acpi alsa amd64 ao artworkextra berkdb bzip2 cairo cdr cleartype cli cracklib crypt cups dbus dri dts dvd dvdr emerald esd exif ffmpeg flac fortran fuse gdbm gif git gnome gnome-keyring gpm gps gstreamer gtk guile hal hddtemp iconv id3tag isdnlog java jpeg laptop libnotify lm_sensors mad midi mmx mono moonlight mp3 mpeg mudflap multilib nautilus ncurses nls nptl nptlonly ogg opengl openmp pam pcre perl png pppd pulseaudio python quicktime raw readline reflection sdl session speechd spell spl sqlite sse sse2 ssl subversion sysfs tcpd tiff truetype unicode vcd vcdinfo vcdx vorbis wifi x264 xcb xorg xprint xulrunner xv xvid zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" ELIBC="glibc" INPUT_DEVICES="keyboard mouse evdev evdev keyboard mouse synaptics" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="en_US en" USERLAND="GNU" VIDEO_CARDS="nvidia nv"
Unset:  CPPFLAGS, CTARGET, FFLAGS, INSTALL_MASK, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

Comment 3 Denis V. Lunev 2009-04-12 08:37:20 UTC
Helps to me.

iris site-packages # pwd
/usr/lib/python2.5/site-packages
iris site-packages # /home/den/bin/gendiff . .fix
--- ./quodlibet/__init__.py.fix	2009-04-12 12:35:47.000000000 +0400
+++ ./quodlibet/__init__.py	2009-04-12 12:36:00.000000000 +0400
@@ -195,7 +195,7 @@ def main(window):
         signal.signal(sig, gtk.main_quit)
 
     window.connect('destroy', gtk.main_quit)
-    window.show()
+    window.show(window)
 
     # This has been known to cause segmentation faults in some Python,
     # GTK+, and GStreamer versions.
iris site-packages # 
Comment 4 Samuli Suominen (RETIRED) gentoo-dev 2009-05-12 13:15:41 UTC
Intresting. Has this been reported upstream?
Comment 5 Samuli Suominen (RETIRED) gentoo-dev 2009-05-12 16:50:49 UTC
+*quodlibet-2.0-r2 (12 May 2009)
+
+  12 May 2009; Samuli Suominen <ssuominen@gentoo.org>
+  +quodlibet-2.0-r2.ebuild, +files/quodlibet-2.0-window.patch:
+  Fix case where Quod Libet doesn't start if it was previously closen with
+  hidden window wrt #262658, patch by Denis V. Lunev.
Comment 6 Samuli Suominen (RETIRED) gentoo-dev 2009-05-12 16:59:46 UTC
Reopening, it doesn't work actually properly.
Comment 7 Samuli Suominen (RETIRED) gentoo-dev 2009-06-03 01:24:45 UTC
(In reply to comment #4)
> Intresting. Has this been reported upstream?
> 

Asking again, ..
Comment 8 Justin Rittenhouse 2009-06-03 13:34:35 UTC
(In reply to comment #7)
> (In reply to comment #4)
> > Intresting. Has this been reported upstream?
> > 
> 
> Asking again, ..
> 

Checked upstream today, and this has been reported upstream.  See http://code.google.com/p/quodlibet/issues/detail?id=146&can=1&q=start
It looks like someone has already referenced this bug in the upstream issue as well.
Comment 9 Samuli Suominen (RETIRED) gentoo-dev 2009-07-16 15:54:39 UTC
2.1 in portage, but I guess the problem is still there? (the upstream bug is open)
Comment 10 Justin Rittenhouse 2009-07-18 02:15:01 UTC
(In reply to comment #9)
> 2.1 in portage, but I guess the problem is still there? (the upstream bug is
> open)
> 

I read through the upstream bug, and it sounds like some form of fix made its way into 2.1.  I upgraded today and tested, and it looks as if 2.1 does have a fix of some sort, at least on my system.  It also sounds like some form of enhancement is going to be included in 2.2.  Currently the fix seems to be that if icon_window_visible = false, on load it is ignored and the window is restored.  It may be that the program will start hidden in 2.2.

Does this work for anyone else?
Comment 11 Samuli Suominen (RETIRED) gentoo-dev 2009-07-19 15:21:01 UTC
Closing per last comment since the actual problem is gone; and the rest seems like enhancement to be discussed in the upstream bug.