Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 261889 - media-video/dvdrip doesn't check required USE flags of transcode
Summary: media-video/dvdrip doesn't check required USE flags of transcode
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: High normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
: 262028 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-03-09 18:11 UTC by Atanas Kamburov
Modified: 2009-03-10 20:02 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
dvdrip-0.98.10-r1.ebuild.diff (dvdrip-0.98.10-r1.ebuild.diff,581 bytes, patch)
2009-03-10 05:39 UTC, Lars Wendler (Polynomial-C) (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Atanas Kamburov 2009-03-09 18:11:17 UTC
After the first pass in a two-pass DVD rip, which lasted 3 hours, DVDrip stopped with an error message that lame support is not enabled in transcode.

Reproducible: Always

Steps to Reproduce:
1. emerge media-video/dvdrip, which also emerges the dependancy media-video/transcode
2. try ripping a dvd with mp3 audio coding
3.

Actual Results:  
dvdrip stops with error message after the first pass


Maybe it would be better to check the USE flags of transcode while emerging DVDrip, and at least print a message of which USE flags of transcode are mandatory/recommended for dvdrip. Even better would be, to make the options offered by dvdrip on the use flags of the dvdrip dependancies, but maybe this is the job of the dvdrip devs...

Thanks!
Comment 1 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2009-03-09 18:24:54 UTC
Well, with EAPI-2 and USE flag dependencies, this should be no big deal. The question is, should this be switchable via USE flag inside of the dvdrip ebuild or should it be hard-enabled?

Reassigning to video herd.
Comment 2 Steve Dibb (RETIRED) gentoo-dev 2009-03-09 20:09:02 UTC
(In reply to comment #1)
> Well, with EAPI-2 and USE flag dependencies, this should be no big deal. The
> question is, should this be switchable via USE flag inside of the dvdrip ebuild
> or should it be hard-enabled?
> 
> Reassigning to video herd.
> 

In this case, since dvd::rip displays the option regardless of whether or not transcode supports it, we'll pull it in.
Comment 3 Steve Dibb (RETIRED) gentoo-dev 2009-03-09 20:12:29 UTC
Added jpeg,mp3,mpeg,ogg,vorbis to transcode dep on dvdrip-0.98.9-r1.ebuild and dvdrip-0.98.10-r1.ebuild
Comment 4 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2009-03-09 20:21:27 UTC
(In reply to comment #2)
> In this case, since dvd::rip displays the option regardless of whether or not
> transcode supports it, we'll pull it in.

I agree. Thanks for fixing this so quickly :)
Comment 5 Atanas Kamburov 2009-03-09 20:58:03 UTC
Thanks! That's great, that's gentoo.
Comment 6 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2009-03-09 22:14:11 UTC
Unfortunately this broke the dependency-tree with =transcode-1.1*:

!!! Multiple package instances within a single package slot have been pulled
!!! into the dependency graph, resulting in a slot conflict:

media-video/transcode:0

  ('installed', '/', 'media-video/transcode-1.1.1-r3', 'nomerge') pulled in by
    media-video/transcode required by ('installed', '/', 'app-cdr/k3b-1.0.5-r3', 'nomerge')
    media-video/transcode[mjpeg] required by ('ebuild', '/', 'media-video/dvdrip-0.98.10-r1', 'merge')

  ('ebuild', '/', 'media-video/transcode-1.0.7', 'merge') pulled in by
    media-video/transcode[dvdread,jpeg,mp3,mpeg,ogg,vorbis] required by ('ebuild', '/', 'media-video/dvdrip-0.98.10-r1', 'merge')
    (and 2 more)

transcode-1.1.1-r3 has no mpeg USE flag.

Reopening...
Comment 7 Jon Malachowski 2009-03-10 04:13:18 UTC
I have the same problem as Lars (Polynomial-C).  because transcode-1.1 (which dvdrip-0.98.10 supports) does not have a mpeg use flag, the requirement forces an unnecessary downgrade.  Removing the requirement from the dvdrip ebuild fixes it for me.

--- dvdrip-0.98.10-r1.ebuild    2009-03-10 00:08:49.000000000 -0400
+++ dvdrip-0.98.10-r2.ebuild    2009-03-10 00:09:33.000000000 -0400
@@ -21,7 +21,7 @@
        >=dev-perl/gtk2-ex-formfactory-0.65
        >=dev-perl/libintl-perl-1.16
        media-gfx/imagemagick
-       media-video/transcode[dvdread,jpeg,mp3,mpeg,ogg,vorbis]"
+       media-video/transcode[dvdread,jpeg,mp3,ogg,vorbis]"
 RDEPEND="${DEPEND}
        x11-libs/gtk+:2[jpeg]
        ffmpeg? ( media-video/ffmpeg )
Comment 8 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2009-03-10 05:39:14 UTC
Created attachment 184524 [details, diff]
dvdrip-0.98.10-r1.ebuild.diff

How about this small patch?
Comment 9 Victor Mataré 2009-03-10 13:42:41 UTC
(In reply to comment #8)
> Created an attachment (id=184524) [edit]
> dvdrip-0.98.10-r1.ebuild.diff
> 
> How about this small patch?
> 

Thumbs up! Please commit ASAP. Transcode 1.1 doesn't have an mpeg use flag anymore, which breaks updates.
Comment 10 Steve Dibb (RETIRED) gentoo-dev 2009-03-10 17:34:37 UTC
Fixed in -r2
Comment 11 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2009-03-10 20:02:31 UTC
*** Bug 262028 has been marked as a duplicate of this bug. ***