Bug 261602 – media-libs/libspiff-1.0.0: Missing media-gfx/graphviz dependency and other minor issues

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Sebastian Pipping 2009-03-07 18:40:18 UTC]

See attached patch for details.

Reproducible: Always

[Comment 1 Sebastian Pipping 2009-03-07 18:41:23 UTC]

Created attachment 184256 [details, diff]
Various fixes for libspiff-1.0.0.ebuild

[Comment 2 Lars Wendler (Polynomial-C) (RETIRED) 2009-03-09 17:26:10 UTC]

Well, the attached patch is full with "cosmetic" fixes which don't really improve the ebuild.
Could you maybe explain why libspiff-1.0.0 needs media-gfx/graphviz? I just installed libspiff without graphviz being installed and the installation finished flawlessly.
Please re-open this bug when you provide the requested information.

[Comment 3 Sebastian Pipping 2009-03-09 20:49:11 UTC]

(In reply to comment #2)
> Well, the attached patch is full with "cosmetic" fixes which don't really
> improve the ebuild.

They do:  The doc install location is changed and more files are installed.  libSpiff ships C bindings which have their own doc which was not installed by the original ebuild.

Before:
- C++ docs go to [pkgdocdir]/html

After:
- C++ docs go to [pkgdocdir]/html/libspiff
- C docs go to [pkgdocdir]/html/spiff_c


> Could you maybe explain why libspiff-1.0.0 needs media-gfx/graphviz? I just
> installed libspiff without graphviz being installed and the installation
> finished flawlessly.

You had the doc flag disabled I suppose?
Doxygen calls dot of graphiz to generate images for the documentation.  No graphiz - no images.

[Comment 4 Lars Wendler (Polynomial-C) (RETIRED) 2009-03-09 21:16:47 UTC]

(In reply to comment #3)
> (In reply to comment #2)
> > Well, the attached patch is full with "cosmetic" fixes which don't really
> > improve the ebuild.
> 
> They do:  The doc install location is changed and more files are installed. 
> libSpiff ships C bindings which have their own doc which was not installed by
> the original ebuild.
> 
> Before:
> - C++ docs go to [pkgdocdir]/html
> 
> After:
> - C++ docs go to [pkgdocdir]/html/libspiff
> - C docs go to [pkgdocdir]/html/spiff_c

May I then kindly request you to apply a new patch that doesn't "fix" quoting everywhere in the ebuild? Furthermore the slash at the end of HOMEPAGE's URL is as useless as the 
  || die "epatch failed"
chunk (epatch dies on its own when a patch fails).
To make it short, please don't do useless beautifying but stick to the relevant changes in the patch.

> > Could you maybe explain why libspiff-1.0.0 needs media-gfx/graphviz? I just
> > installed libspiff without graphviz being installed and the installation
> > finished flawlessly.
> 
> You had the doc flag disabled I suppose?
> Doxygen calls dot of graphiz to generate images for the documentation.  No
> graphiz - no images.

True I had -doc in USE. My fault, shame on me :)

Reassigning to sound herd.

[Comment 5 Sebastian Pipping 2009-03-09 21:34:48 UTC]

(In reply to comment #4)
> May I then kindly request you to apply a new patch that doesn't "fix" quoting
> everywhere in the ebuild?

I could do that.  Why "fix" in quotes?  Did I make a mistake?


> Furthermore the slash at the end of HOMEPAGE's URL is
> as useless

It's not.  I fixed bad practise.  The more sane URLs people see the more sane URLs people write.


> as the 
>   || die "epatch failed"
> chunk (epatch dies on its own when a patch fails).

I didn't know, thanks.


> To make it short, please don't do useless beautifying but stick to the relevant
> changes in the patch.

You should be more careful with the word "useless".

[Comment 6 Sebastian Pipping 2009-03-09 21:44:24 UTC]

Created attachment 184504 [details, diff]
Doc generation fixes for libspiff-1.0.0.ebuild

Removed non-functional changes from patch as requested.

[Comment 7 Sebastian Pipping 2009-04-07 18:21:03 UTC]

Any news?

[Comment 8 Samuli Suominen (RETIRED) 2009-05-10 19:50:35 UTC]

This is fixed in media-libs/libxspf-1.2.0, renamed libspiff.. I will remove this version from tree, 1.0.0