Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 261362 - New ebuild:app-cdr/furiusisomount
Summary: New ebuild:app-cdr/furiusisomount
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Low enhancement (vote)
Assignee: Default Assignee for New Packages
URL: http://www.marcus-furius.com/?page_id=14
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2009-03-05 20:34 UTC by siebz0r
Modified: 2014-12-15 15:19 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild for app-cdr/furiusisomount-0.11.3.1 (furiusisomount-0.11.3.1.ebuild,1.59 KB, text/plain)
2011-09-23 21:52 UTC, Moritz Schlarb
Details
ebuild for app-cdr/furiusisomount-0.11.3.1 (updated) (furiusisomount-0.11.3.1.ebuild,1.59 KB, text/plain)
2011-09-28 20:40 UTC, Moritz Schlarb
Details
ebuild for app-cdr/furiusisomount-0.11.3.1 (updated again) (furiusisomount-0.11.3.1.ebuild,2.02 KB, text/plain)
2011-10-01 11:51 UTC, Moritz Schlarb
Details

Note You need to log in before you can comment on or make changes to this bug.
Description siebz0r 2009-03-05 20:34:52 UTC
ebuild request furius

Reproducible: Always




I'd like to see an ebuild of the furius iso mounting tool.

It's much easyer then going into the console and mounting it as a loop.
Comment 1 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2009-03-05 21:18:59 UTC
Reassigning to maintainer-wanted.
Comment 2 Gilles Dartiguelongue (RETIRED) gentoo-dev 2009-03-07 12:54:29 UTC
there are various ways to mount isos from gnome GUI so I don't think we'll pick this up.
Comment 3 Moritz Schlarb 2011-09-23 21:52:02 UTC
Created attachment 287557 [details]
ebuild for app-cdr/furiusisomount-0.11.3.1

This is an ebuild file for app-cdr/furiusisomount-0.11.3.1 (current version).
It's my first functional ebuild, so please give me QA feedback as much as you can (well, and test it, I'm not quite sure about the dependencies).

Regards,
Moritz
Comment 4 Maxim Koltsov (RETIRED) gentoo-dev 2011-09-24 14:08:03 UTC
Please use python.eclass, particulary PYTHON_DEPEND and PYTHON_USE_WITH. Consider reading http://www.gentoo.org/proj/en/Python/developersguide.xml.
Use 'doins -r' instead of for loop.
Installation of python files to /usr/share is bas idea. Try to make setup.py file and use distutils.eclass.
Comment 5 Alec Meyers 2011-09-24 15:52:12 UTC
(In reply to comment #3)
> please give me QA feedback as much as you can

In the sed statement, you can use delimiters other than '/' - that is, "s/hello/world/" is equivalent to "s:hello:world:". That way, you no longer have to escape the /-es in the paths, and it's *much* more readable.
Comment 6 Alexandre Rostovtsev (RETIRED) gentoo-dev 2011-09-26 01:16:03 UTC
(In reply to comment #2)
> there are various ways to mount isos from gnome GUI so I don't think we'll pick
> this up.

There are lots of ways to mount .iso images in gnome - but not .bin or .mdf images (the only gnome-based graphical tool for mounting them that I know of is gcdemu). So this program does have a niche.

(In reply to comment #3)
> It's my first functional ebuild, so please give me QA feedback

In addition to what Maxim and Alec pointed out:

* HOMEPAGE should probably be http://www.marcus-furius.com/?page_id=170
* gksu and brasero should be in the list of runtime dependencies.
* Instead of "mv ${PN}_${PV} ${P}", it's stylistically better to do
MY_P=${PN}_${PV}
SRC_URI="http://launchpad.net/furiusisomount/python/${PV}/+download/${MY_P}.tar.gz"
S="${WORKDIR}/${MY_P}"
* If you are not using distutils, make sure to use python_mod_optimize and python_mod_cleanup from python.eclass.
* pygtk-based programs do not work with python-3.x, so you need to ensure that /usr/bin/furiusisomount calls python2, not python.
Comment 7 Moritz Schlarb 2011-09-28 20:40:25 UTC
Created attachment 288127 [details]
ebuild for app-cdr/furiusisomount-0.11.3.1 (updated)

I've updated my ebuild file, it now uses python.eclass and doins -r (which I didn't use, because I didn't now it existed, because it's not mentioned in the developer handbook).
I've contacted the upstream developer to ask for a setup.py but haven't received response yet.
Comment 8 Maxim Koltsov (RETIRED) gentoo-dev 2011-09-29 09:50:20 UTC
>	doins src/aboutbox.py src/log.py src/main.py src/filehash.py src/messagebox.py src/globals.py src/imageaction.py
Why not just 'doins src/*.py'?
Comment 9 Moritz Schlarb 2011-10-01 11:51:05 UTC
Created attachment 288431 [details]
ebuild for app-cdr/furiusisomount-0.11.3.1 (updated again)

I've updated the ebuild again, I added use flag brasero and a conditional dependency for it. Also i do some patching in the gui to disable burning buttons, when they are not functional. 
As soon as I receive password for commiting to sunrise, I will do so.

One question that came to my mind: Is app-cdr the right category, or shouldn't it be app-misc or something like that?
Comment 10 Maxim Koltsov (RETIRED) gentoo-dev 2011-10-01 12:35:24 UTC
app-cdr is ok, as soon as cdemu is there. But are you sure we need that 'sed' thing?
Comment 11 Moritz Schlarb 2011-10-01 13:06:24 UTC
This is now in the sunrise overlay. You can find it at:
http://overlays.gentoo.org/proj/sunrise/browser/sunrise/app-cdr/furiusisomount

(In reply to comment #10)
> app-cdr is ok, as soon as cdemu is there. But are you sure we need that 'sed'
> thing?

We don't need it, clicking those buttons will try to invoke nautilus-cd-burner or brasero, which will silently fail if the programs don't exist.
I still didn't reach the upstream developer, I would suggest that he implements some logic, that checks if these programs exist and if not, disable the buttons in the program itself.
Comment 12 Thomas Sachau gentoo-dev 2014-12-14 14:02:01 UTC
The ebuild in sunrise was outdated and unmaintained, so it got removed.