Bug 261311 – [x11 overlay] gallium support for media-libs/mesa-9999

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Thomas Pegeot 2009-03-05 13:29:26 UTC]

Hi,

Gallium entered the mainline Mesa code-base a few days ago, so i wrote a small patch to enable it. ;)

Reproducible: Always

[Comment 1 Thomas Pegeot 2009-03-05 13:30:17 UTC]

Created attachment 184008 [details, diff]
Patch to enable gallium support

[Comment 2 Rémi Cardona (RETIRED) 2009-03-08 16:12:43 UTC]

Just a quick question, why are you disabling the intel gallium driver? Is it broken? Is it enabled by default?

If it doesn't do any harm, then you might as well just leave out the option.

Cheers

[Comment 3 Thomas Pegeot 2009-03-08 20:23:46 UTC]

Yes it is enabled by default : 
./configure --help : 
  --disable-gallium       build gallium [default=enabled]                     
  --disable-gallium-intel build gallium intel [default=enabled]               
  --enable-gallium-radeon build gallium radeon [default=disabled]             
  --enable-gallium-nouveau                                                    
                          build gallium nouveau [default=disabled]   

I thought it was better to disable it by default but as it doesn't do any harm, we can keep it enabled. 

Cheers

[Comment 4 Rémi Cardona (RETIRED) 2009-03-08 21:51:03 UTC]

Ahha, I think I get why you wrote your patch that way. :)

The thing is, an ebuild shouldn't depend on the default values that the configure script has.

So I think it should be something like that instead :

myconf="${myconf} $(use_enable gallium)"

if use gallium; then
	myconf="${myconf}
		$(use_enable video_cards_nouveau gallium-nouveau)
		$(use_enable video_cards_ati gallium-radeon)
		$(use_enable video_cards_intel gallium-intel)"
fi

(NB, I just wrote this code directly in bugzilla, it's 100% untested)

With this kind of code, the ebuild never assumes that gallium is enabled or disabled and it reduces bugs down the line.

Could you try cooking a new patch with something like that?

Cheers :)

[Comment 5 Tomáš Chvátal (RETIRED) 2009-03-23 20:27:21 UTC]

> Could you try cooking a new patch with something like that?

I was bit boored so i cooked it myself ;]

So now 9999 ebuilds supports noveau, radeonhd and in addition this mess (gallium) :]

[Comment 6 David Heidelberg (okias) 2009-03-25 13:28:00 UTC]

Please add DRI2 state tracker support in case NOUVEAU. Thanks

Example for manual compiling: ./configure --enable-debug --enable-glx-tls --disable-asm --with-dri-drivers= --disable-gallium-intel --enable-gallium-nouveau --with-state-trackers=glx,dri2 --with-demos=

[Comment 7 Rémi Cardona (RETIRED) 2009-03-25 13:42:17 UTC]

(In reply to comment #6)
> Please add DRI2 state tracker support in case NOUVEAU. Thanks

Any reason why you would want to add it only when building nouveau?

Thanks

[Comment 8 David Heidelberg (okias) 2009-03-25 13:43:53 UTC]

Created attachment 186226 [details]
Patch to fix nouveau build. Added DRI2 tracker

[Comment 9 David Heidelberg (okias) 2009-03-25 14:15:18 UTC]

Only nouveau need it for build, but you can do it default for all gallium drivers...

[Comment 10 David Heidelberg (okias) 2009-03-25 17:44:10 UTC]

Fixed, OK.