Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 260024 - media-tv/xbmc-9999 cannot find input file Makefile.include
Summary: media-tv/xbmc-9999 cannot find input file Makefile.include
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: SpanKY
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-23 16:00 UTC by Christopher Friedt
Modified: 2009-02-25 19:19 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,150.88 KB, text/plain)
2009-02-23 16:01 UTC, Christopher Friedt
Details
config.log (config.log,124.85 KB, text/plain)
2009-02-23 16:01 UTC, Christopher Friedt
Details
patch for media-tv/xbmc-9999.ebuild (xbmc-9999-ebuild-eautoreconf.patch,527 bytes, patch)
2009-02-23 16:48 UTC, Christopher Friedt
Details | Diff
xbmc-9999-ebuild-conditionally-patch-fribidi-based-on-version.patch (xbmc-9999-ebuild-conditionally-patch-fribidi-based-on-version.patch,484 bytes, patch)
2009-02-24 00:29 UTC, Christopher Friedt
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Friedt 2009-02-23 16:00:24 UTC
I was just trying out the recently added xbmc svn ebuild, and I encounter an error that can easily be fixed by running eautoreconf from within the ebuild. 

Check out the attachments for build.log and config.log .
Comment 1 Christopher Friedt 2009-02-23 16:01:14 UTC
Created attachment 182910 [details]
build.log
Comment 2 Christopher Friedt 2009-02-23 16:01:41 UTC
Created attachment 182911 [details]
config.log
Comment 3 Christopher Friedt 2009-02-23 16:05:21 UTC
The problem is that Makefile.include is not auto-generated from Makefile.include.in, even though it is specified in configure.in

AC_CONFIG_FILES([Makefile Makefile.include]

Running autoreconf from within the source directory fixes the problem. 

Please see my patch for the ebuild, which includes adding eautoreconf before econf is called. 

Comment 4 Christopher Friedt 2009-02-23 16:48:07 UTC
Created attachment 182912 [details, diff]
patch for media-tv/xbmc-9999.ebuild
Comment 5 Christopher Friedt 2009-02-24 00:29:07 UTC
Created attachment 182978 [details, diff]
xbmc-9999-ebuild-conditionally-patch-fribidi-based-on-version.patch

In some cases the xbmc-fribidi.patch should not be applied. Namely, when the installed dev-libs/fribidi version < 0.19.1 . 

This is a patch against the ebuild to patch based on that condition.
Comment 6 SpanKY gentoo-dev 2009-02-24 21:53:00 UTC
Makefile.include is generated by configure based on Makefile.include.in

Makefile.include.in is in svn
Comment 7 Christopher Friedt 2009-02-25 01:54:28 UTC
(In reply to comment #6)
> Makefile.include is generated by configure based on Makefile.include.in
> 
> Makefile.include.in is in svn
> 

I would assume so as well, but if you read my build.log, econf was run, and it still complained about a missing Makefile.include . eautoreconf fixed the problem. 
Comment 8 SpanKY gentoo-dev 2009-02-25 02:26:15 UTC
no, build.log says it couldnt find "Makefile.include.in"

update your svn checkout

the xbmc ebuild specifically avoids running autotools
Comment 9 Christopher Friedt 2009-02-25 14:23:57 UTC
(In reply to comment #8)
> no, build.log says it couldnt find "Makefile.include.in"
> 
> update your svn checkout
> 
> the xbmc ebuild specifically avoids running autotools
> 

Jeez ... that's embarrassing. I must have been thrown off by the ^M character.

Thanks
Comment 10 SpanKY gentoo-dev 2009-02-25 17:05:57 UTC
maybe there were some ^M gremlins floating in the configure and they fixed it upstream.  does it work for you now with latest svn up ?
Comment 11 Christopher Friedt 2009-02-25 19:19:26 UTC
(In reply to comment #10)
> maybe there were some ^M gremlins floating in the configure and they fixed it
> upstream.  does it work for you now with latest svn up ?
> 

It's good! 7 points!