Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 259963 - net-mail/mlmmj-1.2.16 perl admin webinterface does not check returncodes
Summary: net-mail/mlmmj-1.2.16 perl admin webinterface does not check returncodes
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Net-Mail Packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-23 02:04 UTC by Florian Streibelt
Modified: 2011-06-06 12:36 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Streibelt 2009-02-23 02:04:39 UTC
again in subcribers.cgi.
the webinterface does not check the returncode of the subscribe-command but instead tries to find out itself in advance if the mailadress is vaild.

If the call fails due to some other reason (maybe because they use another regex to check the address there) we will still get a success message :(

 97            if ($email =~ /^[a-z0-9\.\-_\@]+$/i) {
 98                 if ($subscriber) {
 99                         system "$mlmmjsub -L $topdir/$list -a $email -U -s";
100                 }
101                 if ($digester) {
102                         system "$mlmmjsub -L $topdir/$list -a $email -Ud -s";
103                 }
104                 if ($nomailsub) {
105                         system "$mlmmjsub -L $topdir/$list -a $email -Un -s";
106                 }
107                 $action .= "$email has been subscribed.<br>\n";
108            } else {
109                 $action .= '"'.encode_entities($email).'" is not a valid email address.<br>';
110            }


Reproducible: Always

Steps to Reproduce:
Comment 1 Florian Streibelt 2009-02-23 02:13:45 UTC
in the very same file some lines below you will find some code that ALWAYS spits out your subscription failed, even when it worked out.

" error adding foo@bar.de (code 0) "

{this code was never tested, was it} ;=)



116         if ($email =~ /^[a-z0-9\.\-_\@]+$/i) {
117                 if ($subscriber) {
118                         system "$mlmmjsub -L $topdir/$list -a $email -U -s";
119                 }
120                 if ($digester) {
121                         system "$mlmmjsub -L $topdir/$list -a $email -Ud -s";
122                 }
123                 if ($nomailsub) {
124                         system "$mlmmjsub -L $topdir/$list -a $email -Un -s";
125                 }
126                 $action = "error adding $email (code $?)";
127         } else {
128                 $action = '"'.encode_entities($email).'" is not a valid email address.';

Comment 2 Robert Buchholz (RETIRED) gentoo-dev 2009-07-11 00:14:28 UTC
please report upstream: http://mlmmj.org/project/issues/mlmmj
Comment 3 Eray Aslan gentoo-dev 2011-06-06 12:36:43 UTC
Closing.  Please inform if you do report upstream.