Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 259818 - app-shells/bash-completion-20081219: irritating hg module for mercurial
Summary: app-shells/bash-completion-20081219: irritating hg module for mercurial
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Jeremy Olexa (darkside) (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 259724
  Show dependency tree
 
Reported: 2009-02-21 15:26 UTC by Martin von Gagern
Modified: 2009-02-23 19:38 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin von Gagern 2009-02-21 15:26:04 UTC
Looking at my latest list of available bash completions, I was surprised to find both "hg" and "mercurial". qfile told me that the mercurial module comes from dev-util/mercurial-1.1.2 while app-shells/bash-completion-20081219 shipped the hg module. In analogy to the way subversion is handled, you might wish to rename the hg module to _mercurial.
Comment 1 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2009-02-21 16:39:08 UTC
Upstream completely dropped the hg module because upstream's was better. In your opinion, should I do the same? Please test them out and let me know. thx
Comment 2 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2009-02-21 16:40:25 UTC
Sorry, upstream b-c dropped the module because upstream mercurial's was better.
Comment 3 Martin von Gagern 2009-02-21 17:54:25 UTC
I'm not a regular mercurial user, but looking at both, I'd suggest doing the same, for a number of reasons:
1. Right now, mercurial seems better than hg because
1.1. it deals with more options, e.g. --cwd
1.2. it provides more features, e.g. _hg_emails customization
1.3. it uses hg debugcomplete instead of hackish awked help output
2. It is more likely to stay in sync with mercurials capabilities
3. If upstream b-c dropped it, doing the same eases maintainance
4. Having only one module avoids confusion (true for subversion as well)

Main argument in favor of the hg module would be code size and thus memory footprint and stuff like that. But as people worried about such things usually wouldn't have bash-completion enabled at all, I think that's a weak argument.

One thing I'm a bit worried about is that mercurial sets the extglob shell option, but there are a number of other packages doing the same. I just filed bug 259835 about this whole extglob business, especially wrt. monotone.
Comment 4 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2009-02-21 18:54:04 UTC
I agree. 20081219-r1 rm's contrib/hg.

b-c upstream commit says:

commit cdec0e5a58ed3388034c5ac74a03ff754de11338
Author: Ville Skyttä <ville.skytta@iki.fi>
Date:   Sun Feb 15 22:50:41 2009 +0200

    Drop hg completion, an improved version is shipped with Mercurial (contrib/bash_completion in the tarball).