Bug 259287 – net-libs/libwww-5.4.0-r7: QA Notice: poor programming practices

• Status: RESOLVED WONTFIX
• Product: Gentoo Linux

[Description Martin Walch 2009-02-16 22:18:50 UTC]

QA Notice: Package has poor programming practices which may compile fine but exhibit random runtime failures.
cvs2sql.c:303: warning: implicit declaration of function 'HTSetTraceMessageMask'
HTBrowse.c:1268: warning: implicit declaration of function 'HText_select'
HTBrowse.c:1593: warning: implicit declaration of function 'HText_selectAnchor'

QA Notice: Package has poor programming practices which may compile fine but exhibit random runtime failures.
HTAssoc.c:132: warning: null argument where non-null required (argument 1)
HTAssoc.c:132: warning: null argument where non-null required (argument 1)
HTAssoc.c:132: warning: null argument where non-null required (argument 1)
HTAssoc.c:132: warning: null argument where non-null required (argument 1)
HTAssoc.c:132: warning: null argument where non-null required (argument 1)
HTAssoc.c:132: warning: null argument where non-null required (argument 1)
HTAssoc.c:132: warning: null argument where non-null required (argument 1)
HTAssoc.c:132: warning: null argument where non-null required (argument 1)
HTRobot.c:403: warning: null argument where non-null required (argument 1)
HTRobot.c:403: warning: null argument where non-null required (argument 1)
HTRobot.c:403: warning: null argument where non-null required (argument 1)
HTRobot.c:403: warning: null argument where non-null required (argument 1)
HTRobot.c:403: warning: null argument where non-null required (argument 1)
HTRobot.c:403: warning: null argument where non-null required (argument 2)
HTRobot.c:403: warning: null argument where non-null required (argument 1)
HTRobot.c:403: warning: null argument where non-null required (argument 1)
HTRobot.c:403: warning: null argument where non-null required (argument 1)
HTRobot.c:403: warning: null argument where non-null required (argument 2)
HTRobot.c:403: warning: null argument where non-null required (argument 1)
HTRobot.c:403: warning: null argument where non-null required (argument 1)
HTRobot.c:403: warning: null argument where non-null required (argument 1)
HTRobot.c:403: warning: null argument where non-null required (argument 2)
HTRobot.c:403: warning: null argument where non-null required (argument 1)
HTRobot.c:403: warning: null argument where non-null required (argument 2)


This should all be fixed with the patch that I will attach in the next comment.

[Comment 1 Martin Walch 2009-02-16 22:27:43 UTC]

Created attachment 182280 [details, diff]
patch, fixing all QA warnings

51_all_libwww-5.4.0-fix-warnings.patch

Should work with any revision of libwww-5.4.0.

[Comment 2 Martin Walch 2009-02-16 22:37:24 UTC]

Created attachment 182284 [details]
patch tarball for easy testing

libwww-5.4.0-patches-1.0.tar.bz2

This is a prepared tarball for patching libwww. Might be more convenient when testing with emerge libwww rather than ebuild libwww unpack, patch <,...

[Comment 3 Michael Palimaka (kensington) 2012-11-18 13:56:31 UTC]

This package is now gone from the tree.