Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 25912 - media-video/mplayer-0.90-r2 does not honor USE=-samba
Summary: media-video/mplayer-0.90-r2 does not honor USE=-samba
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: John Mylchreest (RETIRED)
URL:
Whiteboard:
Keywords:
: 27914 (view as bug list)
Depends on:
Blocks:
 
Reported: 2003-08-04 15:06 UTC by Sascha Silbe
Modified: 2003-09-04 04:48 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Revised ebuild with statements to handle "samba" use flag. (mplayer-0.90-r2.ebuild,11.48 KB, text/plain)
2003-08-05 18:09 UTC, David M. Andersen
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sascha Silbe 2003-08-04 15:06:00 UTC
media-video/mplayer-0.90-r2 always uses Samba, even if the USE flag samba is unset.



Reproducible: Always
Steps to Reproduce:
1. emerge net-fs/samba
2. USE=-samba emerge media-video/mplayer

Actual Results:  
[...]
>>> emerge (1 of 1) media-video/mplayer-0.90-r2 to /
[...]
Checking for Samba support (libsmbclient) ... yes
[...]


Expected Results:  
Disable samba support.


Portage 2.0.48-r5 (default-x86-1.4, gcc-3.2.3, glibc-2.3.2-r1)
=================================================================
System uname: 2.4.21-cube-2 i686 AMD Athlon(tm) processor
GENTOO_MIRRORS="ftp://ftp.easynet.nl/mirror/gentoo/ http://gentoo.inode.at/ ftp://gentoo.inode.at/source/"
CONFIG_PROTECT="/etc /var/qmail/control /usr/kde/2/share/config /usr/kde/3/share/config /usr/vice/etc /usr/X11R6/lib/X11/xkb /usr/kde/3.1/share/config /usr/share/config"
CONFIG_PROTECT_MASK="/etc/afs/modload /etc/make.globals /etc/afs/C /etc/afs/afsws /etc/gconf /etc/env.d"
PORTDIR="/usr/portage"
DISTDIR="/usr/portage/distfiles"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR_OVERLAY="/usr/local/portage"
USE="x86 foomaticdb libg++ mad gtkhtml gdbm berkdb libwww gtk cdr -3dfx 3dnow -aalib acl afs -alsa apm -arts avi -bonobo crypt -cups dga -directfb doc dvd encode -esd -evo -fbcon -ggi gif -gnome -gnome-libs -gphoto2 -gpm guile hbci -icc -icc-pgo imap imlib ipv6 -java jpeg kde kerberos lcms ldap -matrox maildir mbox mikmod mmx monitor -motif mozilla mpeg -mule mysql nas ncurses nls -odbc oggvorbis opengl oss pam -pcmcia -pda pdflib -perl png -pnp postgres python qt qtmt quicktime readline -ruby samba -sasl sdl slang -slp -snmp socks5 spell ssl -static -svga -tcltk -tcpd tetex tiff truetype -voodoo3 X xml xml2 -xmms xv -zeo zlib"
COMPILER="gcc3"
CHOST="i686-pc-linux-gnu"
CFLAGS="-march=athlon-tbird -O3 -pipe"
CXXFLAGS="-O2 -mcpu=i686 -pipe"
ACCEPT_KEYWORDS="x86"
MAKEOPTS="-j2"
AUTOCLEAN="yes"
SYNC="rsync://hybrid.sascha.silbe.org/gentoo-portage"
FEATURES="sandbox ccache"
Comment 1 David M. Andersen 2003-08-05 18:03:29 UTC
Unified diff.  I think this works.

--- /usr/portage/media-video/mplayer/mplayer-0.90-r2.ebuild 2003-08-05 20:58:02.000000000 -0400
+++ /mplayer-0.90-r2.ebuild 2003-08-05 20:59:14.000000000 -0400
@@ -2,7 +2,7 @@
 # Distributed under the terms of the GNU General Public License v2
 # $Header: /home/cvsroot/gentoo-x86/media-video/mplayer/mplayer-0.90-r2.ebuild,v 1.4 2003/07/16 17:16:23 lu_zero Exp $

-IUSE="dga oss xmms jpeg 3dfx sse matrox sdl X svga ggi oggvorbis 3dnow aalib gnome xv opengl truetype dvd gtk gif esd fbcon encode alsa directfb arts dvb"
+IUSE="dga samba oss xmms jpeg 3dfx sse matrox sdl X svga ggi oggvorbis 3dnow aalib gnome xv opengl truetype dvd gtk gif esd fbcon encode alsa directfb arts dvb"

 inherit eutils

@@ -28,6 +28,7 @@
 # If 'dvd' in USE, only DEPEND on libdvdnav, as
 # we use libdvdkit that comes with.
 RDEPEND="ppc? ( >=media-libs/xvid-0.9.0 )
+ samba? ( net-fs/samba )
  x86? ( >=media-libs/xvid-0.9.0
         >=media-libs/divx4linux-20020418
         >=media-libs/win32codecs-0.60 )
@@ -219,6 +220,10 @@
   && myconf="${myconf} --enable-i18n" \
   || myconf="${myconf} --disable-i18n"

+ use samba \
+  && myconf="${myconf} --enable-smb" \
+  || myconf="${myconf} --disable-smb"
+
  if [ -d /opt/RealPlayer9/Real/Codecs ]
  then
   einfo "Setting REALLIBDIR to /opt/RealPlayer9/Real/Codecs..."
@@ -265,7 +270,6 @@
   --enable-menu \
   --enable-dynamic-plugins \
   --enable-real \
-  --enable-smb \
   --with-reallibdir=${REALLIBDIR} \
   --with-x11incdir=/usr/X11R6/include \
   ${myconf} || die
Comment 2 David M. Andersen 2003-08-05 18:09:45 UTC
Created attachment 15577 [details]
Revised ebuild with statements to handle "samba" use flag.

This is untested, but emerge doesn't die on parsing it...
Comment 3 Heinrich Wendel (RETIRED) gentoo-dev 2003-09-04 02:50:25 UTC
*** Bug 27903 has been marked as a duplicate of this bug. ***
Comment 4 Martin Holzer (RETIRED) gentoo-dev 2003-09-04 03:02:56 UTC
i'll fix this asap
Comment 5 Heinrich Wendel (RETIRED) gentoo-dev 2003-09-04 03:12:57 UTC
i did it already :)
Comment 6 SpanKY gentoo-dev 2003-09-04 04:48:00 UTC
*** Bug 27914 has been marked as a duplicate of this bug. ***