Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 258811 - sys-kernel/tuxonice-sources-2.6.28-r1 panics when "resume=" parameter is passed
Summary: sys-kernel/tuxonice-sources-2.6.28-r1 panics when "resume=" parameter is passed
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: x86 Linux
: High normal (vote)
Assignee: Krzysztof Pawlik (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-13 05:01 UTC by Kingsly John
Modified: 2009-02-16 21:28 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
This is the patch for 2.6.28.1 (just-the-revert.patch.bz2,14.01 KB, application/x-bzip)
2009-02-16 20:20 UTC, Greg
Details
tuxonice patch + reversion patch (reverted.patch.bz2,113.13 KB, application/x-bzip)
2009-02-16 20:39 UTC, Greg
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kingsly John 2009-02-13 05:01:28 UTC
tuxonice-sources-2.6.28-r1 builds fine but panics when booted with a resume= parameter. 
Removing it works fine.


Reproducible: Always

Steps to Reproduce:
1. build kernel
2. boot it with a resume= parameter

Actual Results:  
kernel panics

Expected Results:  
kernel shouldn't panic

Removing the parameter from the menu entries in grub makes the system work fine but suspend/hibernate is disabled and rendering tuxonice unusable.

Issue has been discussed and they have a patch, but it's against 2.6.28.1 
(It applies against 2.6.28 but doesn't build)

More information at 
http://lists.tuxonice.net/lurker/message/20090123.112551.2d122bf3.pt-BR.html
Comment 1 Greg 2009-02-16 02:05:02 UTC
My best recommendation is to upgrade to 2.6.28.1 and apply that patch. Upstream (tuxonice in this case) will have little interest in support older versions of the kernel.
Comment 2 Kingsly John 2009-02-16 05:45:01 UTC
That'll probably cause the genpatches to fail.

2.6.28-r1 should probably be hard masked since tuxonice is the main reason to use this package/ebuild and it doesn't work.
Comment 3 Greg 2009-02-16 20:20:34 UTC
Created attachment 182265 [details]
This is the patch for 2.6.28.1
Comment 4 Krzysztof Pawlik (RETIRED) gentoo-dev 2009-02-16 20:33:58 UTC
The patch fails for me:

 * Applying 1000_linux-2.6.28.1.patch (-p0+) ...                                                                                                                                [ ok ]
 * Applying 1725_alpha-srm-compile-failure.patch (-p0+) ...                                                                                                                     [ ok ]
 * Applying 2000_sctp-fwd-tsn-overflow.patch (-p0+) ...                                                                                                                         [ ok ]
 * Applying 2300_usb-reenable-interface.patch (-p0+) ...                                                                                                                        [ ok ]
 * Applying 2305_uninline-pci-ioremap-bar.patch (-p0+) ...                                                                                                                      [ ok ]
 * Applying 2400_iwl3945-adhoc-disconnect-fix.patch (-p0+) ...                                                                                                                  [ ok ]
 * Applying 2505_macpower-wrong-capacity.patch (-p0+) ...                                                                                                                       [ ok ]
 * Applying 2510_pata-hpt366-boot-hang.patch (-p0+) ...                                                                                                                         [ ok ]
 * Applying 2515_nokia-6300-wrong-capacity.patch (-p0+) ...                                                                                                                     [ ok ]
 * Applying 2700_hda-asus-mic-input.patch (-p0+) ...                                                                                                                            [ ok ]
 * Applying 2705_i915-no-vblank-on-disabled-pipe.patch (-p0+) ...                                                                                                               [ ok ]
 * Applying 2710_i915-set-vblank-flag-correctly.patch (-p0+) ...                                                                                                                [ ok ]
 * Applying 2900_IT8720-chipset-support-and-type-values-fix.patch (-p0+) ...                                                                                                    [ ok ]
 * Applying 4100_dm-bbr.patch (-p0+) ...                                                                                                                                        [ ok ]
 * Applying 4200_fbcondecor-0.9.4.patch (-p0+) ...                                                                                                                              [ ok ]
 * Applying 4300_squashfs-3.4.patch (-p0+) ...                                                                                                                                  [ ok ]
 * Applying 4400_alpha-sysctl-uac.patch (-p0+) ...                                                                                                                              [ ok ]
 * Applying tuxonice-3.0-rc8-for-2.6.28.patch.patch (-p0+) ...                                                                                                                  [ ok ]
 * Applying tuxonice-2.6.28-just-the-revert.patch.patch (-p0+) ...

cmd: patch -p1 --no-backup-if-mismatch --dry-run -f < /storage/tmp/portage/sys-kernel/tuxonice-sources-2.6.28-r2/work/patches/000004/tuxonice-2.6.28-just-the-revert.patch.patch
=======================================================
patching file include/linux/dyn_pageflags.h
patching file kernel/power/Kconfig
patching file kernel/power/power.h
patching file kernel/power/snapshot.c
patching file kernel/power/tuxonice.h
patching file kernel/power/tuxonice_atomic_copy.c
patching file kernel/power/tuxonice_builtin.c
patching file kernel/power/tuxonice_builtin.h
patching file kernel/power/tuxonice_extent.c
patching file kernel/power/tuxonice_file.c
patching file kernel/power/tuxonice_highlevel.c
patching file kernel/power/tuxonice_io.c
Hunk #2 FAILED at 413.
Hunk #6 FAILED at 642.
Hunk #7 FAILED at 657.
Hunk #8 FAILED at 691.
Hunk #9 succeeded at 713 (offset -1 lines).
Hunk #10 succeeded at 778 (offset -1 lines).
Hunk #11 succeeded at 1064 (offset -1 lines).
Hunk #12 succeeded at 1265 (offset -1 lines).
Hunk #13 succeeded at 1322 (offset -1 lines).
4 out of 13 hunks FAILED -- saving rejects to file kernel/power/tuxonice_io.c.rej
patching file kernel/power/tuxonice_pagedir.c
patching file kernel/power/tuxonice_pageflags.c
patching file kernel/power/tuxonice_pageflags.h
patching file kernel/power/tuxonice_prepare_image.c
patching file kernel/power/tuxonice_swap.c
patching file mm/Makefile
patching file mm/dyn_pageflags.c
patching file mm/memory_hotplug.c
Comment 5 Greg 2009-02-16 20:39:39 UTC
Created attachment 182267 [details]
tuxonice patch + reversion patch

Don't know if this will make a difference at all
Comment 6 Krzysztof Pawlik (RETIRED) gentoo-dev 2009-02-16 21:28:53 UTC
2.6.28-r2 used 3.0-rc8 with changes from Nigel to remove swsusp bitmaps code.