Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 258783 - media-tv/nxtvepg-2.8.0 has wrong 'use && do || die' statement
Summary: media-tv/nxtvepg-2.8.0 has wrong 'use && do || die' statement
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Tiziano Müller (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-12 21:06 UTC by René 'Necoro' Neumann
Modified: 2009-08-17 15:20 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
nxtvepg-2.8.0.ebuild.diff (nxtvepg-2.8.0.ebuild.diff,575 bytes, patch)
2009-02-12 21:07 UTC, René 'Necoro' Neumann
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description René 'Necoro' Neumann 2009-02-12 21:06:59 UTC
The ebuild contains the following line - which will make it die whenever the
useflag "unicode" is not set - which does not seem intended:

( use unicode && epatch "${FILESDIR}/nxtvepg-unicode.patch" ) || die "unicode patch failed"
Comment 1 René 'Necoro' Neumann 2009-02-12 21:07:22 UTC
Created attachment 181811 [details, diff]
nxtvepg-2.8.0.ebuild.diff

Patch fixing the issue
Comment 2 Matthias Schwarzott gentoo-dev 2009-02-14 09:48:40 UTC
I like this version more, but both should fix the issue:

if use unicode; then
    epatch "${FILESDIR}/nxtvepg-unicode.patch" || die "unicode patch failed"
fi
Comment 3 Christian Faulhammer (RETIRED) gentoo-dev 2009-08-17 15:20:36 UTC
epatch failes on its own, so no need for any conditional statements.  Fixed in tree.