Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 258676 - dev-python/pycipher doesn't install package, has incorrect licence and pointless wrapper
Summary: dev-python/pycipher doesn't install package, has incorrect licence and pointl...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High major (vote)
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-12 05:27 UTC by James Rowe
Modified: 2010-08-23 12:52 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
pycipher_fixes.patch (pycipher_totally_broken.patch,1.26 KB, patch)
2009-02-12 05:28 UTC, James Rowe
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Rowe 2009-02-12 05:27:42 UTC
The pycipher ebuild calls `newexe' to install a python data file with
invalid arguments for portage's `newexe', so the package isn't even
installed.  It also doesn't need to be executable.

  The licence in the script is a BSD 2-clause, not BSD(the 3-clause
version).

  The wrapper script that is built is wrapping a module with no command
line functionality, it only defines classes, so the wrapper does
nothing.

  The byte-compiled files aren't built either.

  The attached patch fixes these problems, and cleans some minor
whitespace things at the same time.

Thanks,

James

Reproducible: Always
Comment 1 James Rowe 2009-02-12 05:28:26 UTC
Created attachment 181747 [details, diff]
pycipher_fixes.patch
Comment 2 James Rowe 2009-02-12 05:36:36 UTC
  Just out of interest which package manager was this tested with?

  It is likely a bug in whichever package manager's `newexe' if it
re-splits arguments on whitespace boundaries, as it would break if
somebody did use paths with spaces.  May want to test this and
possibly report it
Comment 3 Patrick Lauer gentoo-dev 2009-02-15 11:56:42 UTC
Can't reproduce the doexe issue, but that is broken on so many levels ... where's my napalm? ;)

the /usr/bin/pycipher script needs to be changed, that's not even wrong anymore.
Comment 4 James Rowe 2009-02-15 18:30:32 UTC
(In reply to comment #3)
> Can't reproduce the doexe issue, but that is broken on so many levels ...
> where's my napalm? ;)

  If `newexe' is installing anything I'd be interested to know what package
manager you're using, it reeks of a bug because it would be fiddling with 
the whitespace in its arguments.  The quoting breaks portage's `newexe' script, because of the quoting, you should see an error from the following test when
using the ebuild:

if [[ -z ${T} ]] || [[ -z ${2} ]] ; then
	echo "$0: Need two arguments, old file and new file" 1>&2
	exit 1
fi
Comment 5 James Rowe 2010-08-16 14:28:30 UTC
Looks like this has been mostly fixed since this bug was opened, just without
a comment or closure on this bug.

The ebuild in the tree still has the incorrect license value though.

Thanks
Comment 6 Dirkjan Ochtman (RETIRED) gentoo-dev 2010-08-23 12:52:32 UTC
Thanks for reporting back on that. I've fixed the license.