Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 258657 - media-video/mplayer + compiz: accelerated xv enabler
Summary: media-video/mplayer + compiz: accelerated xv enabler
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-11 23:14 UTC by Jeremy Ebler
Modified: 2009-08-03 20:17 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch for the ebuild (ebuild.patch,457 bytes, patch)
2009-02-11 23:17 UTC, Jeremy Ebler
Details | Diff
enables compiz + accelerated xv (mplayer-compiz.patch,14.91 KB, patch)
2009-02-11 23:18 UTC, Jeremy Ebler
Details | Diff
the Compiz/XV patch, updated for mplayer-1.0_rc2_p20090322 (mplayer-1.0_rc2_p20090322.compiz.patch,14.92 KB, patch)
2009-04-07 03:25 UTC, Juraj Vitko
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Ebler 2009-02-11 23:14:41 UTC
A while ago I stumbled upon a patch for mplayer that makes mplayer, compiz, and accelerated xv video out all play together nicely.

http://www.mail-archive.com/compiz@lists.freedesktop.org/msg02164.html

I've been using a mplayer with this patch for the past few stable gentoo mplayer releases (mplayer-1.0_rc2_p27725-r1.ebuild, mplayer-1.0_rc2_p28058-r1.ebuild, mplayer-1.0_rc2_p28450.ebuild) and I have experienced no problems or instabilities with the patch.

Case 1: Running compiz + unpatched mplayer
no xv, forced to use other video outputs none of which are as practical to most people as xv

Case 2: Running compiz + patched mplayer
xv works!
The only issue I have found is that when you make a video full screen it stretches the video to fill the screen, ignoring aspect ratio

Case 3: No compiz + patched mplayer
Behaves like an unpatched mplayer. xv works like it always does. Fullscreen videos preserve their aspect ratio.
Comment 1 Jeremy Ebler 2009-02-11 23:17:22 UTC
Created attachment 181712 [details, diff]
patch for the ebuild

I'm not sure if it would be better to add a compiz use flag, or whatever. This patch just patches in the compiz-xv patch
Comment 2 Jeremy Ebler 2009-02-11 23:18:07 UTC
Created attachment 181714 [details, diff]
enables compiz + accelerated xv
Comment 3 Reimar Döffinger 2009-03-13 23:35:15 UTC
Better name the use flag buggy_bloated_compiz_hack.
This thing is not in SVN because nobody cut it down to reduce the code duplication (draw_slice, draw_image, get_image are mostly identical for the compiz- and non-compiz case), nor did anyone explain _what exactly_ makes this work compared to the original Xv code (which would allow us to actually understand and cut it down ourselves), thus the code did not even make it to the bug fixing stage of the review (e.g. vo_compiz_get_image is basically completely bogus, probably the code was little or not at all tested with -dr).
In addition, when we asked on the list several people claimed Xv was working just fine for them under compiz, so we did not even find out why it is needed at all and in which cases exactly.
Comment 4 Juraj Vitko 2009-04-07 03:25:36 UTC
Created attachment 187516 [details, diff]
the Compiz/XV patch, updated for mplayer-1.0_rc2_p20090322

Taken from http://smspillaz.googlepages.com/mplayrepatch.patch and updated for mplayer-1.0_rc2_p20090322.

I can confirm that this patch makes life much better for people using Compiz, mplayer, and lots of open windows on constantly running system.

Without this patch, it's not possible to watch HD movies in fullscreen in Compiz, as these get wrong aspect ratio.
The only other workaround is to turn off Compiz before watching a movie, but the change of window managers moves all windows from all viewports to the primary viewport/workspace, which sucks badly.

I don't mind if the use flag is called 'bloated-compiz-patch'. It should be added because it helps and kills no kittens, at least AFAIK.
Comment 5 Steve Dibb (RETIRED) gentoo-dev 2009-04-07 05:36:48 UTC
(In reply to comment #4)
> Created an attachment (id=187516) [edit]
> the Compiz/XV patch, updated for mplayer-1.0_rc2_p20090322
> 
> Taken from http://smspillaz.googlepages.com/mplayrepatch.patch and updated for
> mplayer-1.0_rc2_p20090322.
> 
> I can confirm that this patch makes life much better for people using Compiz,
> mplayer, and lots of open windows on constantly running system.
> 
> Without this patch, it's not possible to watch HD movies in fullscreen in
> Compiz, as these get wrong aspect ratio.
> The only other workaround is to turn off Compiz before watching a movie, but
> the change of window managers moves all windows from all viewports to the
> primary viewport/workspace, which sucks badly.
> 
> I don't mind if the use flag is called 'bloated-compiz-patch'. It should be
> added because it helps and kills no kittens, at least AFAIK.
> 

Patches for new features should be coordinated with upstream directly.

http://www.mplayerhq.hu/DOCS/tech/patches.txt

https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng
Comment 6 crazyraven 2009-06-09 12:54:35 UTC
(In reply to comment #4)
> Created an attachment (id=187516) [edit]
> the Compiz/XV patch, updated for mplayer-1.0_rc2_p20090322
> 
> Taken from http://smspillaz.googlepages.com/mplayrepatch.patch and updated for
> mplayer-1.0_rc2_p20090322.
> 
> I can confirm that this patch makes life much better for people using Compiz,
> mplayer, and lots of open windows on constantly running system.
> 
> Without this patch, it's not possible to watch HD movies in fullscreen in
> Compiz, as these get wrong aspect ratio.
> The only other workaround is to turn off Compiz before watching a movie, but
> the change of window managers moves all windows from all viewports to the
> primary viewport/workspace, which sucks badly.
> 
> I don't mind if the use flag is called 'bloated-compiz-patch'. It should be
> added because it helps and kills no kittens, at least AFAIK.
> 

THNAKS I'm looking for 
(In reply to comment #4)
> Created an attachment (id=187516) [edit]
> the Compiz/XV patch, updated for mplayer-1.0_rc2_p20090322
> 
> Taken from http://smspillaz.googlepages.com/mplayrepatch.patch and updated for
> mplayer-1.0_rc2_p20090322.
> 
> I can confirm that this patch makes life much better for people using Compiz,
> mplayer, and lots of open windows on constantly running system.
> 
> Without this patch, it's not possible to watch HD movies in fullscreen in
> Compiz, as these get wrong aspect ratio.
> The only other workaround is to turn off Compiz before watching a movie, but
> the change of window managers moves all windows from all viewports to the
> primary viewport/workspace, which sucks badly.
> 
> I don't mind if the use flag is called 'bloated-compiz-patch'. It should be
> added because it helps and kills no kittens, at least AFAIK.
> 
I'm really thanks for your patch.

but, could you revise this patch for 16bit depth? I'm using 16bit depth enviroment(gnome)

Thnaks :)
Comment 7 Steve Dibb (RETIRED) gentoo-dev 2009-08-03 20:17:04 UTC
(In reply to comment #5)

> Patches for new features should be coordinated with upstream directly.
> 
> http://www.mplayerhq.hu/DOCS/tech/patches.txt
> 
> https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng
> 

closing as WONTFIX