Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 258498 - app-office/openoffice patches its own patch backup output, and ignores VERSION_CONTROL
Summary: app-office/openoffice patches its own patch backup output, and ignores VERSIO...
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: High normal (vote)
Assignee: Gentoo Office Team
URL: http://qa.openoffice.org/issues/show_...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-10 20:17 UTC by Brad Allen
Modified: 2009-11-28 21:45 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Brad Allen 2009-02-10 20:17:26 UTC
This was originally reported on OpenOffice's bug reporting system as Issue 97950, and as you can see, they referred it to Gentoo; please note, this was filed for OpenOffice 3.0.0, but the bug is still present in 3.0.1 AFAICTRNWTTIH:

Description:	Opened: Sun Jan 11 16:49:00 +0000 2009

The problem manifests like this:

I have Gentoo on AMD 64, so it is virtually rediculous not to build everything
to take advantage of 64 bit (Gentoo does have a binary version, but binary
versions are very unreliable in general -- they just never match the local
system).  This makes a BIG difference in performance and reliability my
platform.  Anyway, OpenOffice 3.0, during building, reveals quite a bug in
OpenOffice's source building process:

transogl-pixmap-to-texture.diff: testing...( patch -l -p0  -d
/var/tmp/paludis/app-office-openoffice-3.0.0/work/ooo/build/ooo300-m9 --dry-run
) <
/var/tmp/paludis/app-office-openoffice-3.0.0/work/ooo/patches/dev300/./transogl-pixmap-to-texture.diff
patching file slideshow/source/engine/OGLTrans/OGLTrans_TransitionerImpl.cxx
vvvvvvvvvvvvvvvvv ERROR STARTS HERE vvvvvvvvvvvvvvvvvvvvvvvvv
can't find file to patch at input line 1093
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff -rup
slideshow/source/engine/OGLTrans-orig/OGLTrans_TransitionerImpl.cxx.orig
slideshow/source/engine/OGLTrans/OGLTrans_TransitionerImpl.cxx.orig
|--- slideshow/source/engine/OGLTrans-orig/OGLTrans_TransitionerImpl.cxx.orig  
2008-08-26 18:06:46.000000000 +0200
|+++ slideshow/source/engine/OGLTrans/OGLTrans_TransitionerImpl.cxx.orig       
2008-08-25 19:10:29.000000000 +0200
--------------------------
File to patch:

Comparing my build process log to logs of others whose build processes succeeded
allowed me to refine my bug manifestation.

Looking at the directory in question at the time of the bug failure, there is no
OGLTrans_TransitionerImpl.cxx.orig, but there certainly is an
OGLTrans_TransitionerImpl.cxx.~1~.  From the "patch" manual page, it is apparent
that openoffice is failing to control its own environment.

A genuine fix for this bug would be for openoffice to stop patching its own
patch backup output.  However, a workaround for now would be for openoffice to
specify the version control for patch to be using outright.  A workaround in
that manner that works for the current assumptions is:

PATCH_VERSION_CONTROL=simple
SIMPLE_BACKUP_PREFIX=.orig
export PATCH_VERSION_CONTROL SIMPLE_BACKUP_PREFIX

A shorthand in my particular situation in my particular build system in Gentoo
ended up being (very implementation dependent, and not general in any way):

VERSION_CONTROL= paludis -i openoffice

Of course, that only works because PATCH_VERSION_CONTROL was not set in my
situation, and VERSION_CONTROL was (and has been since 1995).  If it were, then
that shorthand would not have worked; "PATCH_VERSION_CONTROL=simple
SIMPLE_BACKUP_PREFIX=.orig paludis -i openoffice" would have been the shorthand
workaround in that case.  Anyway, if you fix this problem one way or the other
(using a genuine fix, or by controlling the assumed behavoir of "patch"
specifically), then those shorthands would be irrelevent.
------- Additional comments from frayser Mon Jan 26 11:56:45 +0000 2009 -------

To help confirm this:

I've always had that same problem, trying to build Open Office 3.0.0 and today
3.01_rc2 on Gentoo, because I've had VERSION_CONROL=t set.

By setting PATCH_VERSION_CONTROL=simple(as suggested), I can finally emerge Open
Office and still keep my VERSION_CONTROL=t. I use emerge from sys-apps/portage. 

My version control variables are set in /etc/profile.d/version-control.sh, a
file I created to allow for versioned backups from cp and mv when the -b switch
is given.  
------- Additional comments from dtardon Wed Jan 28 09:04:50 +0000 2009 -------

dtardon->bwa: This one is gentoo/go-oo specific. OpenOffice.org doesn't do any
patching during it's build process. You should report it at bugs.gentoo.org.

Reproducible: Always

Steps to Reproduce:
See description for steps to reproduce.
Actual Results:  
See description for actual results.

Expected Results:  
See description for expected results.

See description for additional information.
Comment 1 Brad Allen 2009-02-10 20:20:14 UTC
URL for OpenOffice bug report that was reffered here:  <http://qa.openoffice.org/issues/show_bug.cgi?id=97950>
Comment 2 Andreas Proschofsky (RETIRED) gentoo-dev 2009-11-28 21:45:17 UTC
This is an upstream bug, please report at 

https://bugzilla.novell.com

which is the upstream for ooo-build. Nothing we can do here.