25831 – FETCHCOMMAND and RESUMECOMMAND in /etc/make.globals are wrong

Bug 25831 - FETCHCOMMAND and RESUMECOMMAND in /etc/make.globals are wrong

Summary: FETCHCOMMAND and RESUMECOMMAND in /etc/make.globals are wrong

Status:	RESOLVED FIXED

Alias:	None

Product:	Portage Development
Classification:	Unclassified
Component:	Core - Configuration (show other bugs)
Hardware:	All Linux

Importance:	High blocker (vote)
Assignee:	Portage team

URL:
Whiteboard:
Keywords:	InVCS

Depends on:
Blocks:

Reported:	2003-08-03 14:29 UTC by Stuart Herbert (RETIRED)
Modified:	2004-02-08 17:55 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Stuart Herbert (RETIRED) gentoo-dev

2003-08-03 14:29:20 UTC

Hi! 
 
Please put quotes around the ${URI} variable in FETCHCOMMAND and RESUMECOMMAND in 
/etc/make.globals.  At the moment, ebuild barfs on URLs that contain ampersands or [ and ], because 
bash can't see that they're part of the parameter. 
 
This is preventing the ioncube-loader ebuild from working. 
 
Thanks, 
Stu

Comment 1 Stuart Herbert (RETIRED) gentoo-dev

2003-08-06 14:05:17 UTC

I'm upgrading this to 'blocker' because I can't commit the latest ebuild for 
ioncube-loaders until this bug is fixed. 
 
Nick, it's a four character change to fix - well, that, and a stable release of portage 
;-).  Could you look at it sometime plz? 
 
Thanks, 
Stu

Comment 2 Robert Moss (RETIRED) gentoo-dev

2003-09-04 14:55:36 UTC

Has this been fixed? portage-2.0.49-r3 appears to be fine with both make.globals and make.conf, although I'm loathe to downgrade to portage-2.0.48-r5 to check this for AMD64 stable users - anyone?

Comment 3 Stuart Herbert (RETIRED) gentoo-dev

2003-09-05 16:46:31 UTC

I didn't spot the fix for this in 2.0.49-r3, but it's always possible I made a mistake 
when I etc-update'd. 
 
Best regards, 
Stu

Comment 4 Martin Holzer (RETIRED) gentoo-dev

2003-10-21 11:59:10 UTC

how  about 2.0.49-r13-2+ ?

Comment 5 Doug Weimer 2003-11-01 09:45:23 UTC

portage-2.0.49-r15 still has this problem. To test I just added '?test1=1&test2=WORKS'
to an ebuilds SRC_URI. The results:

>>> Downloading
http://gentoo.mirrors.pair.com/distfiles/colorgcc-1.3.2.tar.gz?test1=1&test2=WORKS
--09:31:39--  http://gentoo.mirrors.pair.com/distfiles/colorgcc-1.3.2.tar.gz?test1=1
           => `/usr/portage/distfiles/colorgcc-1.3.2.tar.gz?test1=1'

Notice the missing '&test2=WORKS' from wget's url.

Comment 6 Nicholas Jones (RETIRED) gentoo-dev

2003-12-28 22:04:00 UTC

Added to CVS for 2.0.50_pre10

Comment 7 Marius Mauch (RETIRED) gentoo-dev

2004-02-08 17:55:11 UTC

supposed to be fixed in 2.0.50 which is stable now. If this bug is not fixed please reopen.