Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 258300 - sys-devel/prelink-20060712-r1 cron script bashisms
Summary: sys-devel/prelink-20060712-r1 cron script bashisms
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Toolchain Maintainers
URL: https://bugzilla.redhat.com/show_bug....
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-09 07:38 UTC by Felipe Lessa
Modified: 2009-02-16 00:46 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Felipe Lessa 2009-02-09 07:38:46 UTC
The cron job /etc/cron.daily/prelink contain bashisms but the shebang calls /bin/sh. The bashism I spotted is using "/var/lib/misc/prelink.{full,quick}" on lines 34 and 50.

One symptom of the bashisms is receiving syslog errors like the following:

cp: missing destination file operand after `/var/lib/misc/prelink.{full,quick}'
Try `cp --help' for more information.

There may be other users that use something else as /bin/sh, such as dash, so please remove the bashisms or change the shebang to #!/bin/bash.

Thanks! =)

Reproducible: Always

Steps to Reproduce:
1. Use dash as a /bin/sh (ln -sf `which dash` /bin/sh)
2. Run /etc/cron.daily/prelink


Actual Results:  
1. The error message below is printed:

cp: missing destination file operand after `/var/lib/misc/prelink.{full,quick}'
Try `cp --help' for more information.

2. It is impossible to tell if the prelink was successful or not.

Expected Results:  
No messages.

Portage 2.1.6.4 (default/linux/amd64/2008.0, gcc-4.3.3, glibc-2.9_p20081201-r1, 2.6.28-tuxonice-r1 x86_64)
=================================================================
System uname: Linux-2.6.28-tuxonice-r1-x86_64-Intel-R-_Core-TM-2_Duo_CPU_T5450_@_1.66GHz-with-glibc2.2.5
Timestamp of tree: Mon, 09 Feb 2009 06:45:02 +0000
app-shells/bash:     3.2_p39
dev-java/java-config: 1.3.7-r1, 2.1.6-r1
dev-lang/python:     2.5.2-r7
dev-util/cmake:      2.4.8
sys-apps/baselayout: 2.0.0
sys-apps/openrc:     0.4.2
sys-apps/sandbox:    1.2.18.1-r2
sys-devel/autoconf:  2.13, 2.63
sys-devel/automake:  1.5, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10.2
sys-devel/binutils:  2.18-r3
sys-devel/gcc-config: 1.4.0-r4
sys-devel/libtool:   2.2.6a
virtual/os-headers:  2.6.27-r2
ACCEPT_KEYWORDS="amd64"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=core2 -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/share/config"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/splash /etc/terminfo /etc/texmf/web2c /etc/udev/rules.d"
CXXFLAGS="-march=core2 -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="buildpkg distlocks fixpackages parallel-fetch protect-owned sandbox sfperms strict unmerge-orphans userfetch"
GENTOO_MIRRORS="http://www.las.ic.unicamp.br/pub/gentoo/ http://distro.ibiblio.org/pub/linux/distributions/gentoo/ "
LANG="pt_BR.UTF-8"
LC_ALL="pt_BR.UTF8"
LDFLAGS="-Wl,-O1"
LINGUAS="pt_BR pt ja ja_JP"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/portage/local/layman/haskell"
SYNC="rsync://rsync.samerica.gentoo.org/gentoo-portage"
USE="X a52 aac acl acpi adns alsa amd64 amr amrnb amrwb autoipd avahi bash-completion berkdb bluetooth bonjour bzip2 cairo cdr cjk cleartype cli cracklib crypt css cups daap dar64 dbus dga dirac djvu dri dvd dvdr dvdread emacs encode exif fastcgi fbcon ffmpeg flac fontconfig fortran gdbm gif glade glibc-omitfp glitz gmp gnome gnome-keyring gnutls gpm gs gstreamer gtk hal hddtemp iconv id3tag imlib immqt-bc ipv6 isdnlog java javascript jce jpeg kakasi laptop latex libburn libffi libnotify lm_sensors lzo mad matroska mbrola midi mmx mng mono mp3 mpeg msn mtp mudflap mule multilib nautilus ncurses networkmanager nls nptl nptlonly ntp ofx ogg opengl openmp pam pcre pdf perl pidgin png postscript pppd pulseaudio python quicktime readline reflection rtc schroedinger sdl session sound speex spell spl sse sse2 ssl ssse3 startup-notification svg sysfs tcpd theora threads tiff totem truetype type1 unicode usb v4l2 vorbis wifi wmf x264 xattr xcomposite xml xmp xorg xpm xulrunner xv xvid xvmc zeroconf zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" ELIBC="glibc" INPUT_DEVICES="evdev keyboard mouse synaptics" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="pt_BR pt ja ja_JP" USERLAND="GNU" VIDEO_CARDS="i810 i945 intel"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, FFLAGS, INSTALL_MASK, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS