Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 257335 - Cowloop fails to compile under 2.6.28
Summary: Cowloop fails to compile under 2.6.28
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Daniel Black (RETIRED)
URL: http://www.atcomputing.nl/Tools/cowlo...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-02 06:42 UTC by Jérôme Poulin
Modified: 2009-02-02 12:24 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
cowloop-3.0-2.6.28.patch (cowloop-3.0-2.6.28.patch,3.78 KB, patch)
2009-02-02 06:43 UTC, Jérôme Poulin
Details | Diff
cowloop-3.0-r4.ebuild (cowloop-3.0-r4.ebuild,1.69 KB, text/plain)
2009-02-02 06:44 UTC, Jérôme Poulin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jérôme Poulin 2009-02-02 06:42:20 UTC
The summary sums it all, now here are the goodies.
Attached is a patch to make it compile under 2.6.28, I didn't test, however, under 2.6.27/26. If anyone would like to test so we can include #if, that would be appreciated.
Comment 1 Jérôme Poulin 2009-02-02 06:43:17 UTC
Created attachment 180659 [details, diff]
cowloop-3.0-2.6.28.patch

Makes cowloop compiles under 2.6.28 after all the other patches.
Comment 2 Jérôme Poulin 2009-02-02 06:44:07 UTC
Created attachment 180660 [details]
cowloop-3.0-r4.ebuild

This is the updated ebuild to include the patch plus changed arch to ~x86.
Comment 3 Daniel Black (RETIRED) gentoo-dev 2009-02-02 07:31:30 UTC
I assume you've tested the functionality and it work ok? Thanks for the patch - rarely see ones like this. I'll add it soon.
Comment 4 Jérôme Poulin 2009-02-02 07:38:49 UTC
I tested creating a cowdev, writing to it, deleting cowdev, examining the content of the cowfile, merging the cowfile, remounting it, everything is okay in the file. Then I tried rmmod'ing the module, seems like everything cleaned up correctly.
What is not tested is compatibility with 2.6.27 and 2.6.26, I guess there are probably 1 or 2 #IFs to add, but it may also work out-of-the-box.
Comment 5 Daniel Black (RETIRED) gentoo-dev 2009-02-02 12:24:48 UTC
all changes were 2.6.28 and not backwards compatible.
http://www.linuxhq.com/kernel/v2.6/28/fs/block_dev.c

I've done the #if magic and its hopefully right. I'll submit it upstream with credits to you.

thanks