Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 256994 - kde-base/kdepimlibs-4.2.0: compilation fails
Summary: kde-base/kdepimlibs-4.2.0: compilation fails
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] KDE (show other bugs)
Hardware: x86 Linux
: High critical with 1 vote (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-30 21:33 UTC by Michal
Modified: 2009-06-13 10:13 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michal 2009-01-30 21:33:44 UTC
When I try to compile kdepimlibs it fails with this output

>>> Source configured.                                                                               
>>> Compiling source in /var/tmp/portage/kde-base/kdepimlibs-4.2.0/work/kdepimlibs-4.2.0 ...         
make -j3                                                                                             
Scanning dependencies of target imap-handbook                                                        
Scanning dependencies of target kresources-handbook                                                                                         
Scanning dependencies of target ldap-handbook                                                                                               
[  0%] [  0%] [  0%] Generating index.cache.bz2                                                                                             
Generating index.cache.bz2                                                                                                                  
Generating index.cache.bz2                                                                                                                  
index.docbook:77: parser error : Entity 'krunner' not defined                                                                               
<member>Contacts &krunner; plugin</member>                                                                                                  
                          ^                                                                                                                 
make[2]: *** [doc/kcontrol/kresources/index.cache.bz2] Error 1                                                                              
make[1]: *** [doc/kcontrol/kresources/CMakeFiles/kresources-handbook.dir/all] Error 2                                                       
make[1]: *** Waiting for unfinished jobs....                                                                                                
[  0%] Built target ldap-handbook                                                                                                           
[  0%] Built target imap-handbook                                                                                                           
make: *** [all] Error 2                                                                                                                     
 *                                                                                                                                          
 * ERROR: kde-base/kdepimlibs-4.2.0 failed.                                                                                                 
 * Call stack:                                                                                                                              
 *               ebuild.sh, line   49:  Called src_compile                                                                                  
 *             environment, line 3096:  Called kde4-base_src_compile                                                                        
 *             environment, line 2247:  Called kde4-base_src_make                                                                           
 *             environment, line 2307:  Called cmake-utils_src_make                                                                         
 *             environment, line  805:  Called die                                                                                          
 * The specific snippet of code:                                                                                                            
 *           emake "$@" || die "Make failed!";
 *  The die message:
 *   Make failed!
 *
 * If you need support, post the topmost build error, and the call stack if relevant.
 * A complete build log is located at '/var/tmp/portage/kde-base/kdepimlibs-4.2.0/temp/build.log'.
 * The ebuild environment file is located at '/var/tmp/portage/kde-base/kdepimlibs-4.2.0/temp/environment'.
 *


Reproducible: Always

Steps to Reproduce:
1.emerge  kdepimlibs
2.
3.




When I try it manually using make && make install in the /var/tmp/portage/kde-base/kdepimlibs-4.2.0/ folder it compiles without any problem. 
Strange is that when I tried it on else computer with gentoo, the same configuration, gcc, make.conf and there it works. I tried to install the same versions of applications like on the second computer but it didn't help.


Portage 2.2_rc23 (default/linux/x86/2008.0/desktop, gcc-4.3.3, glibc-2.6.1-r0, 2.6.28-gentoo-r1 i686)
=================================================================                                    
System uname: Linux-2.6.28-gentoo-r1-i686-Intel-R-_Core-TM-_Duo_CPU_T2250_@_1.73GHz-with-glibc2.0    
Timestamp of tree: Thu, 29 Jan 2009 20:05:01 +0000                                                   
app-shells/bash:     3.2_p39                                                                         
dev-java/java-config: 1.3.7-r1, 2.1.6-r1                                                             
dev-lang/python:     2.5.4-r2                                                                        
dev-util/cmake:      2.6.2-r1                                                                        
sys-apps/baselayout: 2.0.0                                                                           
sys-apps/openrc:     0.4.2                                                                           
sys-apps/sandbox:    1.2.18.1-r2                                                                     
sys-devel/autoconf:  2.13, 2.63                                                                      
sys-devel/automake:  1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10.2                                            
sys-devel/binutils:  2.18-r3                                                                         
sys-devel/gcc-config: 1.4.0-r4                                                                       
sys-devel/libtool:   2.2.6a                                                                          
virtual/os-headers:  2.6.28-r1                                                                       
ACCEPT_KEYWORDS="x86"                                                                                
CBUILD="i686-pc-linux-gnu"                                                                           
CFLAGS="-march=prescott -O2 -pipe"                                                                   
CHOST="i686-pc-linux-gnu"                                                                            
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/share/config"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/splash /etc/terminfo /etc/texmf/web2c /etc/udev/rules.d"                                                                       
CXXFLAGS="-march=prescott -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="distlocks fixpackages parallel-fetch preserve-libs protect-owned sandbox sfperms strict unmerge-orphans userfetch"
GENTOO_MIRRORS="http://distfiles.gentoo.org http://distro.ibiblio.org/pub/linux/distributions/gentoo"
LANG="cs_CZ.utf8"
LC_ALL="cs_CZ.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="cs"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="X a52 aac aalib acl acpi aiglx alsa bash-completion berkdb bidi bluetooth branding bzip2 cairo cdda cdio cdr cli cracklib crypt cups curl dar32 dbus divx dri dts dvd dvdnav dvdr dvdread eds emboss emerald encode esd evo fam fbcon fbsplash ffmpeg firefox flac fortran freetype gammu gdbm gecko gif gimp glib glib* glitz gpm gstreamer gtk hal httpd iconv ieee1394 ipv6 ipw3945 irda isdnlog jack java jingle jpeg kde kdeenablefinal kdehiddenvisibility kipi latex ldap libcaca libnotify live logitech-mouse mad matroska midi mikmod mjpeg mmx mmxext mp3 mpeg mudflap mysql ncurses nls no-old-linux nptlonly nsplugin obex ogg oggvorbis opengl openmp optimizememory oscar pam pascal pcre pdf perl png ppds pppd print python qt3 qt3support qt4 quicktime rdesktop readline reflection samba scanner sdl session skins slang spell spl sqlite srt sse sse2 ssl startup-notification stream svg svga symlink synaptics sysfs syslog tcpd tetex theora threadsafe threatsafe tiff tls tordns truetype type1 unicode usb vcd vlm vmware vorbis webkit wifi win32codecs wincodecs wmp wxwindows x86 xcomposite xinerama xml xorg xulrunner xv xvid zlib" ALSA_CARDS="hda-intel" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fsdav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" ELIBC="glibc" INPUT_DEVICES="evdev keyboard mouse" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="cs" USERLAND="GNU" VIDEO_CARDS="intel"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, FFLAGS, INSTALL_MASK, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 1 Korvin 2009-02-18 12:08:36 UTC
I have similar problem but with different effect. 
I tried to upgrade KDE4.2.0 to the newly appeared ebuilds but it failed. Particularly kdebase and kdepimlibs has the most errors. kdebase failed to install complaining about slot conflict (_after_ successfull config and compilation), and kdepimlibs even failed to configure:

+ libical                                                                                                                                                    
-----------------------------------------------------------------------------                                                                                
-- The following OPTIONAL packages could NOT be located on your system.                                                                                      
-- Consider installing them to enable more features from this software.                                                                                      
+ OpenLDAP: LDAP (Lightweight Directory Access Protocol) libraries <http://www.openldap.org>                                                                 
STRONGLY RECOMMENDED: Needed to provide LDAP functionality in KDE                                                                                            
-----------------------------------------------------------------------------                                                                                

CMake Error at CMakeLists.txt:128 (macro_write_basic_cmake_version_file):
  Unknown CMake command "macro_write_basic_cmake_version_file".          


-- Configuring incomplete, errors occurred!
 *                                         
 * ERROR: kde-base/kdepimlibs-4.2.0 failed.
 * Call stack:                             
 *               ebuild.sh, line   49:  Called src_configure
 *             environment, line 3181:  Called kde4-base_src_configure
 *             environment, line 2356:  Called cmake-utils_src_configure
 *             environment, line  783:  Called cmake-utils_src_configureout
 *             environment, line  802:  Called die                         
 * The specific snippet of code:                                           
 *       cmake -C "${TMPDIR}/gentoo_common_config.cmake" ${cmakeargs} "${S}" || die "Cmake failed";
 *  The die message:                                                                               
 *   Cmake failed                                                                                  
 *                                                                                                 
 * If you need support, post the topmost build error, and the call stack if relevant.              
 * A complete build log is located at '/var/tmp/portage/kde-base/kdepimlibs-4.2.0/temp/build.log'. 
 * The ebuild environment file is located at '/var/tmp/portage/kde-base/kdepimlibs-4.2.0/temp/environment'.
 *                                                                                                         

>>> Failed to emerge kde-base/kdepimlibs-4.2.0, Log file:

>>>  '/var/tmp/portage/kde-base/kdepimlibs-4.2.0/temp/build.log'


--- Mu emerge --info is

Portage 2.1.6.7 (default/linux/amd64/2008.0, gcc-4.1.2, glibc-2.8_p20080602-r1, 2.6.28-gentoo-r1 x86_64)
=================================================================                                       
System uname: Linux-2.6.28-gentoo-r1-x86_64-AMD_Athlon-tm-_64_X2_Dual-Core_Processor_TK-57-with-glibc2.2.5
Timestamp of tree: Wed, 18 Feb 2009 08:30:01 +0000                                                        
distcc 3.0 x86_64-pc-linux-gnu [disabled]                                                                 
app-shells/bash:     3.2_p39                                                                              
dev-java/java-config: 1.3.7-r1, 2.1.6-r1                                                                  
dev-lang/python:     2.4.4-r13, 2.5.2-r7                                                                  
dev-python/pycrypto: 2.0.1-r6                                                                             
dev-util/cmake:      2.6.2-r1                                                                             
sys-apps/baselayout: 1.12.11.1                                                                            
sys-apps/sandbox:    1.2.18.1-r2                                                                          
sys-devel/autoconf:  2.13, 2.63                                                                           
sys-devel/automake:  1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10.2
sys-devel/binutils:  2.18-r3
sys-devel/gcc-config: 1.4.0-r4
sys-devel/libtool:   1.5.26
virtual/os-headers:  2.6.27-r2
ACCEPT_KEYWORDS="amd64"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O3 -pipe -mmmx -msse -msse2 -m3dnow"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/kde/4.1/env /usr/kde/4.1/share/config /usr/kde/4.1/shutdown /usr/kde/4.2/env /usr/kde/4.2/share/config /usr/kde/4.2/shutdown /usr/share/config"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/revdep-rebuild /etc/terminfo /etc/udev/rules.d"
CXXFLAGS="-O3 -pipe -mmmx -msse -msse2 -m3dnow"
DISTDIR="/usr/portage/distfiles"
FEATURES="distlocks fixpackages parallel-fetch protect-owned sandbox sfperms strict unmerge-orphans userfetch"
GENTOO_MIRRORS="http://fido.online.kz/gentoo http://mirror.yandex.ru/gentoo-distfiles"
LANG="ru_RU.UTF-8"
LC_ALL=""
LDFLAGS="-Wl,-O1"
LINGUAS="ru"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="3dnow X a52 aac acl alsa amd64 berkdb bluetooth bzip2 cli cracklib crypt cups dbus dri dvd dvdr dvdread encode exif fortran gdbm gif gpm gstreamer hal i18n iconv ipv6 isdnlog jpeg kde kdeprefix lm_sensors midi mmx mp3 mpeg mudflap multilib ncurses nls nptl nptlonly ogg opengl openmp pam pcre pdf perl png pppd python qt3support readline reflection samba session smb spl sse sse2 ssl svg sysfs tcpd tiff truetype unicode usb utf8 vorbis wifi xcomposite xinerama xorg zlib" ALSA_CARDS="hda-intel usb-audio usb-usx2y" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_iduserdir usertrack vhost_alias" ELIBC="glibc" INPUT_DEVICES="keyboard mouse evdev synaptics" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="ru" USERLAND="GNU" VIDEO_CARDS="nv vesa"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, FFLAGS, INSTALL_MASK, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, PORTDIR_OVERLAY


Comment 2 Andre LS Meirelles 2009-03-01 03:09:41 UTC
(In reply to comment #1)
I had the exact result as Korvin's. The kdelibs problem was related to the $PREFIX variable beeing /usr/kde/4.1 

This kdepimlibs I haven't figured out yet.

> I have similar problem but with different effect. 
> I tried to upgrade KDE4.2.0 to the newly appeared ebuilds but it failed.
> Particularly kdebase and kdepimlibs has the most errors. kdebase failed to
> install complaining about slot conflict (_after_ successfull config and
> compilation), and kdepimlibs even failed to configure:
> 
> + libical                                                                       
> -----------------------------------------------------------------------------   
> -- The following OPTIONAL packages could NOT be located on your system.         
> -- Consider installing them to enable more features from this software.         
> + OpenLDAP: LDAP (Lightweight Directory Access Protocol) libraries
> <http://www.openldap.org>                                                       
> STRONGLY RECOMMENDED: Needed to provide LDAP functionality in KDE               
> -----------------------------------------------------------------------------   
> 
> CMake Error at CMakeLists.txt:128 (macro_write_basic_cmake_version_file):
>   Unknown CMake command "macro_write_basic_cmake_version_file".          
> 
> 
> -- Configuring incomplete, errors occurred!
>  *                                         
>  * ERROR: kde-base/kdepimlibs-4.2.0 failed.
>  * Call stack:                             
>  *               ebuild.sh, line   49:  Called src_configure
>  *             environment, line 3181:  Called kde4-base_src_configure
>  *             environment, line 2356:  Called cmake-utils_src_configure
>  *             environment, line  783:  Called cmake-utils_src_configureout
>  *             environment, line  802:  Called die                         
>  * The specific snippet of code:                                           
>  *       cmake -C "${TMPDIR}/gentoo_common_config.cmake" ${cmakeargs} "${S}" ||
> die "Cmake failed";
>  *  The die message:                                                            
>  *   Cmake failed                                                               
>  *                                                                              
>  * If you need support, post the topmost build error, and the call stack if
> relevant.              
>  * A complete build log is located at
> '/var/tmp/portage/kde-base/kdepimlibs-4.2.0/temp/build.log'. 
>  * The ebuild environment file is located at
> '/var/tmp/portage/kde-base/kdepimlibs-4.2.0/temp/environment'.
>  *                                                                              
> 
> >>> Failed to emerge kde-base/kdepimlibs-4.2.0, Log file:
> 
> >>>  '/var/tmp/portage/kde-base/kdepimlibs-4.2.0/temp/build.log'
> 
> 
> --- Mu emerge --info is
> 
> Portage 2.1.6.7 (default/linux/amd64/2008.0, gcc-4.1.2, glibc-2.8_p20080602-r1,
> 2.6.28-gentoo-r1 x86_64)
> =================================================================               
> System uname:
> Linux-2.6.28-gentoo-r1-x86_64-AMD_Athlon-tm-_64_X2_Dual-Core_Processor_TK-57-with-glibc2.2.5
> Timestamp of tree: Wed, 18 Feb 2009 08:30:01 +0000                              
> distcc 3.0 x86_64-pc-linux-gnu [disabled]                                       
> app-shells/bash:     3.2_p39                                                    
> dev-java/java-config: 1.3.7-r1, 2.1.6-r1                                        
> dev-lang/python:     2.4.4-r13, 2.5.2-r7                                        
> dev-python/pycrypto: 2.0.1-r6                                                   
> dev-util/cmake:      2.6.2-r1                                                   
> sys-apps/baselayout: 1.12.11.1                                                  
> sys-apps/sandbox:    1.2.18.1-r2                                                
> sys-devel/autoconf:  2.13, 2.63                                                 
> sys-devel/automake:  1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10.2
> sys-devel/binutils:  2.18-r3
> sys-devel/gcc-config: 1.4.0-r4
> sys-devel/libtool:   1.5.26
> virtual/os-headers:  2.6.27-r2
> ACCEPT_KEYWORDS="amd64"
> CBUILD="x86_64-pc-linux-gnu"
> CFLAGS="-O3 -pipe -mmmx -msse -msse2 -m3dnow"
> CHOST="x86_64-pc-linux-gnu"
> CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config
> /usr/kde/3.5/shutdown /usr/kde/4.1/env /usr/kde/4.1/share/config
> /usr/kde/4.1/shutdown /usr/kde/4.2/env /usr/kde/4.2/share/config
> /usr/kde/4.2/shutdown /usr/share/config"
> CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/
> /etc/fonts/fonts.conf /etc/gconf /etc/revdep-rebuild /etc/terminfo
> /etc/udev/rules.d"
> CXXFLAGS="-O3 -pipe -mmmx -msse -msse2 -m3dnow"
> DISTDIR="/usr/portage/distfiles"
> FEATURES="distlocks fixpackages parallel-fetch protect-owned sandbox sfperms
> strict unmerge-orphans userfetch"
> GENTOO_MIRRORS="http://fido.online.kz/gentoo
> http://mirror.yandex.ru/gentoo-distfiles"
> LANG="ru_RU.UTF-8"
> LC_ALL=""
> LDFLAGS="-Wl,-O1"
> LINGUAS="ru"
> MAKEOPTS="-j3"
> PKGDIR="/usr/portage/packages"
> PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress
> --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles
> --exclude=/local --exclude=/packages"
> PORTAGE_TMPDIR="/var/tmp"
> PORTDIR="/usr/portage"
> SYNC="rsync://rsync.gentoo.org/gentoo-portage"
> USE="3dnow X a52 aac acl alsa amd64 berkdb bluetooth bzip2 cli cracklib crypt
> cups dbus dri dvd dvdr dvdread encode exif fortran gdbm gif gpm gstreamer hal
> i18n iconv ipv6 isdnlog jpeg kde kdeprefix lm_sensors midi mmx mp3 mpeg mudflap
> multilib ncurses nls nptl nptlonly ogg opengl openmp pam pcre pdf perl png pppd
> python qt3support readline reflection samba session smb spl sse sse2 ssl svg
> sysfs tcpd tiff truetype unicode usb utf8 vorbis wifi xcomposite xinerama xorg
> zlib" ALSA_CARDS="hda-intel usb-audio usb-usx2y" ALSA_PCM_PLUGINS="adpcm alaw
> asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa
> lfloat linear meter mmap_emul mulaw multi null plug rate route share shm
> softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon
> authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile
> authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate
> dir disk_cache env expires ext_filter file_cache filter headers include info
> log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling
> status unique_iduserdir usertrack vhost_alias" ELIBC="glibc"
> INPUT_DEVICES="keyboard mouse evdev synaptics" KERNEL="linux"
> LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses
> text" LINGUAS="ru" USERLAND="GNU" VIDEO_CARDS="nv vesa"
> Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, FFLAGS, INSTALL_MASK,
> PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS,
> PORTDIR_OVERLAY
> 

Comment 3 Maciej Mrozowski gentoo-dev 2009-05-30 01:32:00 UTC
Please try to reproduce with recent portage tree (emerge --sync) and with KDE-4.2.3 (emerge --verboase --ask --deep --ypdate world is recommended)
Comment 4 Tomáš Chvátal (RETIRED) gentoo-dev 2009-06-11 18:01:10 UTC
For me it looks like yet another old eclass bug :]
And it is fixed with the new one.
Since no response here, closing.