Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 256992 - net-print/cups-1.3.9-r1: condense avahi and zeroconf USE flags
Summary: net-print/cups-1.3.9-r1: condense avahi and zeroconf USE flags
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement
Assignee: Printing Team
URL:
Whiteboard:
Keywords:
: 268415 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-01-30 21:07 UTC by Pacho Ramos
Modified: 2009-09-13 11:02 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
cups.ebuild.diff (cups.ebuild.diff,3.28 KB, patch)
2009-01-30 21:17 UTC, Pacho Ramos
Details | Diff
A simple clean up (move_avahi_mdnsresponder-compat_to_COMMON_DEPEND.diff,1.03 KB, patch)
2009-06-25 09:48 UTC, Pierre Dumuid
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pacho Ramos gentoo-dev 2009-01-30 21:07:41 UTC
This was discussed in the past in:
http://www.mail-archive.com/gentoo-dev@lists.gentoo.org/msg31489.html

The attached diff will make needed changes for merging avahi and zerconf USE flags in simply "zeroconf", this will be interesting for a lot of people that tends to suffer blockers because of their USEs in make.conf, as a lot of different combinations of zeroconf, bonjour, avahi, mdnsresponder, howl are being used. 



Reproducible: Always
Comment 1 Pacho Ramos gentoo-dev 2009-01-30 21:17:17 UTC
Created attachment 180318 [details, diff]
cups.ebuild.diff

The changes are the following:
1. Move to EAPI=2, this allows to simply a bit more the ebuild in some phases
2. Depend on net-dns/avahi[mdnsresponder-compat], this allows to drop USE flag checking in pkg_setup
3. Apply patches in src_prepare phase, this way, unpack ${A} && cd "${S}" can be dropped
4. Run configure in src_configure
5. As "avahi" USE flag is dropped and "zeroconf" USE flag has a more general sense, I use "has_version" for setting neededservices variable
____

Maybe "good-gs" stuff in pkg_postinst could be also dropped if cups would PDEPEND on ghostscript* compiled with "cups" USE flag, but I am not sure about how should I do that, as seems that virtual/ghostscript doesn't have any USE flag, maybe an option would be depend on any of the ghostscript with something like:
        || (    app-text/ghostscript-gpl[cups]
                app-text/ghostscript-esp[cups]
                app-text/ghostscript-gnu[cups]
        )

But I am not sure if this is the proper way to go :-/

Thanks for the information
Comment 2 Timo Gurr (RETIRED) gentoo-dev 2009-05-04 07:20:11 UTC
*** Bug 268415 has been marked as a duplicate of this bug. ***
Comment 3 Pierre Dumuid 2009-06-25 09:48:58 UTC
Created attachment 195741 [details, diff]
A simple clean up

This patch to cups-1.3.10-r1.ebuild removes the message for avahi requiring the mdnsresponder-compat use flag, and gets portage to require that flag.  (So that after enabling the use flag, portage knows that avahi requires that package to be re-emerged).

Was about to file it under a new bug, but since this bug is about cleaning up, I wasn't sure if I should.
Comment 4 Timo Gurr (RETIRED) gentoo-dev 2009-09-13 11:02:07 UTC
Many thanks to both of you for your patches, fix is in >=cups-1.4 in CVS.