Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 256741 - sys-apps/sandbox-1.3.3 fails on Gentoo/FreeBSD.
Summary: sys-apps/sandbox-1.3.3 fails on Gentoo/FreeBSD.
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: FreeBSD (show other bugs)
Hardware: All FreeBSD
: High normal (vote)
Assignee: Sandbox Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-29 03:00 UTC by Javier Villavicencio (RETIRED)
Modified: 2009-01-29 16:45 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Javier Villavicencio (RETIRED) gentoo-dev 2009-01-29 03:00:48 UTC
Again :+). 
Two failures this time.
First one, sandbox tries to link against libdl due to "sandbox_LDADD" in src/Makefile.am -- To fix:

-sandbox_LDADD = $(top_builddir)/libsbutil/libsbutil.la -ldl
+sandbox_LDADD = $(top_builddir)/libsbutil/libsbutil.la $(LIBDL)

Second one, *another* non-existing strndup case:

/bin/sh ../libtool --tag=CC   --mode=link i686-gentoo-freebsd7.1-gcc  -O2 -march=k8 -pipe -Wall -o sandbox environ.o sandbox.o ../libsbutil/libsbutil.la  -lc
libtool: link: i686-gentoo-freebsd7.1-gcc -O2 -march=k8 -pipe -Wall -o sandbox environ.o sandbox.o  ../libsbutil/.libs/libsbutil.a
../libsbutil/.libs/libsbutil.a(sb_memory.o): In function `__xstrndup':
sb_memory.c:(.text+0x28): undefined reference to `strndup'
collect2: ld returned 1 exit status
gmake[2]: *** [sandbox] Error 1

The configure script already checks for strndup, so this one could be fixed easily I guess. 
However, since I'll probably backport strndup anyway, take the 2nd one as FYI only, I'll be dropping keyword on this version for now if that's ok.
Comment 1 SpanKY gentoo-dev 2009-01-29 03:36:27 UTC
the strndup failure has always been there in 1.3.x, it just wasnt a hard failure before because undefined references in shared libraries were ignored.  in other words, i doubt sandbox-1.3.x has ever been usable for you.

i was able to eliminate all but one strndup() instances (since most were stupid: calling strnlen() by using strlen()).  i imagine if you guys wanted, you could scrub that one last instance with a simple xmalloc/memcpy ...

the libdl things was obvious, sorry about that:
http://git.overlays.gentoo.org/gitweb/?p=proj/sandbox.git;a=commitdiff;h=25ec463eb4ba49c2c82ad0e7e82ed48799be4f4d
Comment 2 Javier Villavicencio (RETIRED) gentoo-dev 2009-01-29 07:21:23 UTC
(In reply to comment #1)
> the strndup failure has always been there in 1.3.x, it just wasnt a hard
> failure before because undefined references in shared libraries were ignored. 
> in other words, i doubt sandbox-1.3.x has ever been usable for you.
> 
Weird, sandbox 1.3.2 was working fine for me. Played with it under sandboxshell and it even barks on net-misc/rsync-3.0.5 ./configure step when the mknod/FIFOs tests are done (why it doesn't barks on linux?).

> i was able to eliminate all but one strndup() instances (since most were
> stupid: calling strnlen() by using strlen()).  i imagine if you guys wanted,
> you could scrub that one last instance with a simple xmalloc/memcpy ...
> 

Nevermind, adding strndup was easier/fast enough.

> the libdl things was obvious, sorry about that:
> http://git.overlays.gentoo.org/gitweb/?p=proj/sandbox.git;a=commitdiff;h=25ec463eb4ba49c2c82ad0e7e82ed48799be4f4d
> 

Thanks. I dropped keywords on sandbox 1.3.3, close this one when 1.3.4 goes in.
Comment 4 Javier Villavicencio (RETIRED) gentoo-dev 2009-01-29 07:44:05 UTC
LOL, want another bug (mknod FIFO one on rsync configure)?
Comment 5 SpanKY gentoo-dev 2009-01-29 16:45:45 UTC
yes, new bug please