Bug 256681 – sci-libs/cfitsio-3.100-r1 stabilisation request

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Paul Price 2009-01-28 20:19:48 UTC]

We have used cfitsio 3.100 (with some minor fixes) for some time now on AMD64 and x86 platforms, with no problems.  Suggest this version is marked stable after adding the below fixes.

Reproducible: Always

Steps to Reproduce:




Added some additional protection against NULL pointer dereferences (when extname == NULL).  I think Bill Pence knows about these, and I expect they will be fixed in the next public release.


--- cfitsio3100-pap/edithdu.c   2008-10-09 09:57:05.000000000 -1000
+++ cfitsio3100/edithdu.c       2008-08-18 06:02:20.000000000 -1000
@@ -556,9 +556,7 @@
         return(*status);
  
     extnm[0] = '\0';
-    if (extnmx) {
         strncat(extnm, extnmx, FLEN_VALUE-1);
-    }
  
     if (fptr->HDUposition != (fptr->Fptr)->curhdu)
         ffmahd(fptr, (fptr->HDUposition) + 1, NULL, status);
@@ -694,9 +692,7 @@
         return(*status);
  
     extnm[0] = '\0';
-    if (extnmx) {
         strncat(extnm, extnmx, FLEN_VALUE-1);
-    }
  
     if (fptr->HDUposition != (fptr->Fptr)->curhdu)
         ffmahd(fptr, (fptr->HDUposition) + 1, NULL, status);


--- cfitsio3100-pap/putkey.c    2008-10-09 09:47:40.000000000 -1000
+++ cfitsio3100/putkey.c        2008-08-13 09:48:18.000000000 -1000
@@ -2729,9 +2729,7 @@
     }
  
     xtension[0] = '\0';
-    if (xtensionx) {
         strncat(xtension, xtensionx, FLEN_VALUE-1);
-    }
  
     ffpkys(fptr, "XTENSION", xtension, "extension type", status);
     ffpkyj(fptr, "BITPIX",   bitpix,   "number of bits per data pixel", status);

[Comment 1 Sébastien Fabbro (RETIRED) 2009-01-31 12:43:54 UTC]

Hi Paul,

Thanks for the warning and the fix. I updated the cfitsio to 3.100-r1 with your patch.
Concerning stabilization, we wait normally one month once the package has no open bug. But since we did not ask for this one for several months, I'll ask our arch teams in a week if nothing has appeared with 3.100-r1.

[Comment 2 Steve Arnold 2009-02-09 04:01:36 UTC]

Hmm, don't see any new bugs...  Time to start stabling cfitsio-3.100-r1?

[Comment 3 Jeroen Roovers (RETIRED) 2009-02-09 04:56:26 UTC]

Stable for HPPA:
 dev-lang/cfortran-4.4-r2 
 sci-libs/cfitsio-3.100-r1

[Comment 4 Tobias Klausmann (RETIRED) 2009-02-09 18:13:49 UTC]

Stable on alpha. (also stabilized cfortran-4.4-r2 which was only keyworded).

Couldn't run the test suite since it uses insane amounts of disk space (over 11G!) and eventually filled up my filesystem.

[Comment 5 Markus Meier 2009-02-09 20:32:56 UTC]

amd64/x86 stable

[Comment 6 Brent Baude (RETIRED) 2009-02-27 20:32:02 UTC]

ppc64 stable

[Comment 7 Brent Baude (RETIRED) 2009-03-20 14:00:28 UTC]

ppc stable

[Comment 8 Friedrich Oslage (RETIRED) 2009-03-28 13:31:23 UTC]

sparc stable, closing