diff against media-sound/seq24-0.9.0: --- /usr/portage/media-sound/seq24/seq24-0.9.0.ebuild 2008-11-29 14:27:14.000000000 +0100 +++ seq24-0.9.0.ebuild 2009-01-25 15:43:14.000000000 +0100 @@ -34,4 +34,6 @@ src_configure() { src_install() { emake DESTDIR="${D}" install || die dodoc AUTHORS ChangeLog README RTC SEQ24 + doicon src/seq24_32.xpm + make_desktop_entry seq24 seq24 seq24_32.xpm }
fixed in CVS.
The doicon line sounds tremendously _wrong_. The icon should be installed in /usr/share/icons/hicolor/32x32/apps/seq24.xpm (and if there are other sizes they should be installed too) and the icon name in the .desktop files should be just seq24. Icon theme specifications are clear on that and I think even desktop-file-validate will throw a warning if the .xpm extension is set explicitly.
how about newicon src/seq24_32.xpm seq24.xpm make_desktop_entry seq24
Why not installing the icons in the right place?
1) it's not part of any icon theme 2) ask it to newicon() ;)
hicolor is exactly where stuff NOT from icon themes get installed. As for (do|new)icon, I think I already exposed the flaw some time ago but there it seemed difficult to provide an easy way to guess the size of the icon and so it wasn't possible to keep the same interface.
so, what do you suggest? using insinto+(do|new)ins instead of (do|new)icon?
Well.. /usr/share/pixmaps is still valid location, changed the ebuild a bit so the desktop entry is following the spec (used newicon, removed the .xpm ending from the Icon= entry)
