Bug 256135 – sys-apps/kexec-tools-2.0.0: Ignored LDFLAGS

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Arfrever Frehtes Taifersar Arahesis (RETIRED) 2009-01-23 22:04:01 UTC]

sys-apps/kexec-tools-2.0.0 ignores LDFLAGS.

 * QA Notice: Files built without respecting LDFLAGS have been detected
 *  Please include the following list of files in your report:         
 * /usr/sbin/kdump

[Comment 1 Arfrever Frehtes Taifersar Arahesis (RETIRED) 2009-01-23 22:04:53 UTC]

Created attachment 179480 [details, diff]
kexec-tools-2.0.0-respect-LDFLAGS.patch

[Comment 2 Jeremy Olexa (darkside) (RETIRED) 2009-01-23 22:15:51 UTC]

Thanks, I was working on a patch last night but then forgot to commit it. Will get to soon.

[Comment 3 Jeremy Olexa (darkside) (RETIRED) 2009-01-25 01:29:21 UTC]

Arfrever: Why is your patch better than:

-   $(CC) $(CFLAGS) $(EXTRA_CFLAGS) -o $@ $(KDUMP_OBJS)
+   $(CC) $(CFLAGS) $(EXTRA_CFLAGS) $(LDFLAGS) -o $@ $(KDUMP_OBJS)

?

[Comment 4 Arfrever Frehtes Taifersar Arahesis (RETIRED) 2009-01-25 01:36:30 UTC]

KDUMP_OBJS contains only .o files, so no compilation is performed, so CFLAGS aren't needed.

[Comment 5 Jeremy Olexa (darkside) (RETIRED) 2009-01-25 01:43:22 UTC]

(In reply to comment #4)
> KDUMP_OBJS contains only .o files, so no compilation is performed, so CFLAGS
> aren't needed.
> 

Great, thanks.