Changes in the v4l headers break compilation of qc-usb-0.6.6-r1 Reproducible: Always Steps to Reproduce: 1. emerge kernel-sources >= 2.6.28 2. emerge qc-usb 3. watch it fails Actual Results: /var/tmp/portage/media-video/qc-usb-0.6.6-r1/work/qc-usb-0.6.6/qc-driver.c: In function ‘qc_i2c_init’: /var/tmp/portage/media-video/qc-usb-0.6.6-r1/work/qc-usb-0.6.6/qc-driver.c:827: attention : assignment from incompatible pointer type /var/tmp/portage/media-video/qc-usb-0.6.6-r1/work/qc-usb-0.6.6/qc-driver.c: In function ‘qc_isoc_start’: /var/tmp/portage/media-video/qc-usb-0.6.6-r1/work/qc-usb-0.6.6/qc-driver.c:1869: attention : assignment from incompatible pointer type /var/tmp/portage/media-video/qc-usb-0.6.6-r1/work/qc-usb-0.6.6/qc-driver.c: In function ‘qc_v4l_poll’: /var/tmp/portage/media-video/qc-usb-0.6.6-r1/work/qc-usb-0.6.6/qc-driver.c:2258: erreur: ‘struct video_device’ has no member named ‘priv’ /var/tmp/portage/media-video/qc-usb-0.6.6-r1/work/qc-usb-0.6.6/qc-driver.c: In function ‘qc_v4l_open’: /var/tmp/portage/media-video/qc-usb-0.6.6-r1/work/qc-usb-0.6.6/qc-driver.c:2310: erreur: ‘struct video_device’ has no member named ‘priv’ /var/tmp/portage/media-video/qc-usb-0.6.6-r1/work/qc-usb-0.6.6/qc-driver.c: In function ‘qc_v4l_close’: /var/tmp/portage/media-video/qc-usb-0.6.6-r1/work/qc-usb-0.6.6/qc-driver.c:2378: erreur: ‘struct video_device’ has no member named ‘priv’ /var/tmp/portage/media-video/qc-usb-0.6.6-r1/work/qc-usb-0.6.6/qc-driver.c: In function ‘qc_v4l_read’: /var/tmp/portage/media-video/qc-usb-0.6.6-r1/work/qc-usb-0.6.6/qc-driver.c:2426: erreur: ‘struct video_device’ has no member named ‘priv’ /var/tmp/portage/media-video/qc-usb-0.6.6-r1/work/qc-usb-0.6.6/qc-driver.c: In function ‘qc_v4l_mmap’: /var/tmp/portage/media-video/qc-usb-0.6.6-r1/work/qc-usb-0.6.6/qc-driver.c:2481: erreur: ‘struct video_device’ has no member named ‘priv’ /var/tmp/portage/media-video/qc-usb-0.6.6-r1/work/qc-usb-0.6.6/qc-driver.c: In function ‘qc_v4l_ioctl’: /var/tmp/portage/media-video/qc-usb-0.6.6-r1/work/qc-usb-0.6.6/qc-driver.c:2513: erreur: ‘struct video_device’ has no member named ‘priv’ /var/tmp/portage/media-video/qc-usb-0.6.6-r1/work/qc-usb-0.6.6/qc-driver.c: In function ‘qc_usb_init’: /var/tmp/portage/media-video/qc-usb-0.6.6-r1/work/qc-usb-0.6.6/qc-driver.c:3164: erreur: ‘struct video_device’ has no member named ‘priv’ make[2]: *** [/var/tmp/portage/media-video/qc-usb-0.6.6-r1/work/qc-usb-0.6.6/qc-driver.o] Erreur 1 make[2]: *** Attente des tâches non terminées.... make[1]: *** [_module_/var/tmp/portage/media-video/qc-usb-0.6.6-r1/work/qc-usb-0.6.6] Erreur 2 make[1]: quittant le répertoire « /usr/src/linux-2.6.28-gentoo » make: *** [quickcam.ko] Erreur 2
Created attachment 178090 [details, diff] Patch correcting the compiling issues This patch corrects the compilation issues.
Created attachment 178091 [details] Updated ebuild An updated version of the ebuild including the patch
nice, thanks for the patch, I'll review asap but don't hesitate to kick back in a week if it's still not commited.
Created attachment 178111 [details, diff] Patch correcting the compiling issues Correcting a typo in the patch
The patch "qc-usb-0.6.6-kcompat-2.6.28.patch" should go to the portage tree. i modified the qc-usb-0.6.6-r1.ebuild and added these lines to "src_unpack() {}": if kernel_is ge 2 6 28; then # Fix compilation with 2.6.28 epatch "${FILESDIR}/${P}-kcompat-2.6.28.patch" fi ...and it compiled and worked!
in tree as 0.6.6-r2. Thanks for reporting and the patch.
*** Bug 261215 has been marked as a duplicate of this bug. ***
*** Bug 263480 has been marked as a duplicate of this bug. ***
