Bug 254302 – media-sound/mpdscribble - Bad start-stop-daemon flag in init.d script

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Dominik Kozaczko 2009-01-09 12:05:01 UTC]

There is a little bug in media-sound/mpdscribble-0.13 and media-sound/mpdscribble-0.15:
/etc/init.d/mpdscribble script has option "-b" for start-stop-daemon in stop() function, which prevents it from executing. This results in adding mpdscribble instances upon "restart" and leaving mpdscribble running after "stop". Correct initscript in attachment.

Reproducible: Always

[Comment 1 Dominik Kozaczko 2009-01-09 12:05:47 UTC]

Created attachment 177864 [details]
Correct initscript for mpdscribble

[Comment 2 Dominik Kozaczko 2009-01-09 12:09:33 UTC]

I meant "-m", not "-b" but the attachment is ok ;)

[Comment 3 Jeroen Roovers (RETIRED) 2009-01-09 14:59:06 UTC]

gentoo-x86/media-sound/mpdscribble $ wget 'https://bugs.gentoo.org/attachment.cgi?id=177864' -O - | diff -u files/mpdscribble.rc -
--2009-01-09 15:58:15--  https://bugs.gentoo.org/attachment.cgi?id=177864
Resolving bugs.gentoo.org... 85.17.225.93
Connecting to bugs.gentoo.org|85.17.225.93|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 470 [text/plain]
Saving to: `STDOUT'

100%[==========================================================>] 470         --.-K/s   in 0s

2009-01-09 15:58:15 (12.3 MB/s) - `-' saved [470/470]

--- files/mpdscribble.rc        2006-06-22 22:47:20.000000000 +0200
+++ -   2009-01-09 15:58:15.272248334 +0100
@@ -14,7 +14,7 @@

 stop () {
        ebegin "Stopping Music Player Daemon Audioscrobbler client"
-       start-stop-daemon --stop --quiet -p /var/run/mpdscribble.pid -m --exec /usr/bin/mpdscribble || eerror "mpdscribble is not running"
+       start-stop-daemon --stop --quiet -p /var/run/mpdscribble.pid --exec /usr/bin/mpdscribble || eerror "mpdscribble is not running"
        rm -f /var/run/mpdscribble.pid
        eend $?
 }

[Comment 4 Christoph Mende (RETIRED) 2009-01-19 01:02:19 UTC]

thanks, fixed