254179 – media-libs/tiff - (unapplied) ${FILESDIR}/tiff-buffer.patch introduces badness

Bug 254179 - media-libs/tiff - (unapplied) ${FILESDIR}/tiff-buffer.patch introduces badness

Summary: media-libs/tiff - (unapplied) ${FILESDIR}/tiff-buffer.patch introduces badness

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	Steve Arnold

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2009-01-08 00:38 UTC by Mike Lundy
Modified:	2009-05-09 10:55 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Mike Lundy 2009-01-08 00:38:37 UTC

the tiff-buffer patch in the tree introduces a possible stack problem:

-sprintf(buffer, "\\%.3o", pdfstr[i]);
+snprintf(buffer, "\\%.3o", pdfstr[i]);

it switches to snprintf without providing another arg. This isn't really a nasty problem because the patch isn't applied to any of the tiff ebuilds. It should probably either be fixed and applied, or removed from the tree.

Reproducible: Always

Steps to Reproduce:

Comment 1 Samuli Suominen (RETIRED) gentoo-dev

2009-05-09 10:55:38 UTC

+  09 May 2009; Samuli Suominen <ssuominen@gentoo.org>
+  -files/tiff-buffer.patch:
+  Remove unused patch wrt #254179