builtin-add.c: In function 'cmd_add': builtin-add.c:266: warning: implicit declaration of function 'validate_pathspec' builtin-add.c:266: warning: assignment makes pointer from integer without a cast builtin-add.c: At top level: builtin-add.c:18: warning: 'patch_interactive' defined but not used builtin-add.c:18: warning: 'add_interactive' defined but not used builtin-add.o: In function `cmd_add': builtin-add.c:(.text+0x153): undefined reference to `validate_pathspec' collect2: ld returned 1 exit status make: *** [git] Error 1 [ebuild U ] dev-util/git-1.6.1 [1.6.0.6] USE="iconv threads vim-syntax -bash-completion -cgi -curl -cvs -doc -emacs -gtk -mozsha1 -perl (-ppcsha1) -subversion -tk -webdav -xinetd" 0 kB Portage 2.1.6.4 (default/linux/x86/2008.0/desktop, gcc-4.3.2, glibc-2.9_p20081201-r1, 2.6.28-gentoo i686) ================================================================= System uname: Linux-2.6.28-gentoo-i686-Genuine_Intel-R-_CPU_T2400_@_1.83GHz-with-glibc2.0 Timestamp of tree: Tue, 06 Jan 2009 23:15:01 +0000 app-shells/bash: 3.2_p48 dev-java/java-config: 1.3.7-r1, 2.1.6-r1 dev-lang/python: 2.5.2-r8 sys-apps/baselayout: 2.0.0 sys-apps/openrc: 0.4.1-r1 sys-apps/sandbox: 1.3.2 sys-devel/autoconf: 2.13, 2.63 sys-devel/automake: 1.5, 1.9.6-r2, 1.10.2 sys-devel/binutils: 2.19 sys-devel/gcc-config: 1.4.0-r4 sys-devel/libtool: 2.2.6a virtual/os-headers: 2.6.28-r1 ACCEPT_KEYWORDS="x86 ~x86" CBUILD="i686-pc-linux-gnu" CFLAGS="-Os -march=native -fomit-frame-pointer -pipe" CHOST="i686-pc-linux-gnu" CONFIG_PROTECT="/etc" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/udev/rules.d" CXXFLAGS="-Os -march=native -fomit-frame-pointer -pipe" DISTDIR="/usr/portage/distfiles" FEATURES="distlocks fixpackages parallel-fetch protect-owned sandbox sfperms strict unmerge-orphans userfetch" GENTOO_MIRRORS="ftp://gentoo.osuosl.org/pub/gentoo" LANG="en_CA.UTF-8" LDFLAGS="-Wl,-O1" LINGUAS="en en_US" MAKEOPTS="-j3 -s" PKGDIR="/usr/portage/packages" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages" PORTAGE_TMPDIR="/var/tmp" PORTDIR="/usr/portage" PORTDIR_OVERLAY="/usr/local/portage" SYNC="rsync://rsync.ca.gentoo.org/gentoo-portage" USE="X a52 acpi aio alsa async bzip2 cairo cdio custom-cflags custom-optimization cxx dvd expat fam gecko gif glibc-omitfp glitz hpn iconv id3 idn jpeg mad midi mmx mmxext mp3 multiuser ncurses nethack network-cron nptl nsplugin ogg opengl pam pcre png quicktime readline rtc sha512 sse sse2 ssl ssse3 svg symlink sysvipc theora threads threadsafe truetype unicode urandom vim-syntax vim-with-x vorbis webdav-neon win32codecs x264 x86 xcb xinerama xorg xscreensaver xulrunner xv xvid zlib zsh-completion" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" ELIBC="glibc" INPUT_DEVICES="evdev synaptics" KERNEL="linux" LINGUAS="en en_US" USERLAND="GNU" VIDEO_CARDS="none nvidia" Unset: CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, FFLAGS, INSTALL_MASK, LC_ALL, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Reassigning to / CCing maintainers.
This bug gets triggered when the perl USE flag is unset. Adjusting summary.
I can confirm this bug.
I'm seeing it too.
Any progress?
I had the same problem while building without the perl use-flag. But I modified the noperl patch in order to work with git 1.6.1 and for me it's working very well. While compiling there are just these two warning like I had in den git 1.6.0.6 ebuild: builtin-add.c:18: warning: 'patch_interactive' defined but not used builtin-add.c:18: warning: 'add_interactive' defined but not used I attach the git-1.6.1-r1.ebuild and a slightly modified noperl patch. I hope it solves this problem for everyone. Have a nice day.
Created attachment 178049 [details] git-1.6.1-r1 ebuild
Created attachment 178051 [details, diff] new version of the git noperl patch for git 1.6.1
This patch works for me.
As I wrote in comment 6 the patch throws two warnings while compiling builtin-add.c in line 18. I will attach a new version of the noperl patch for git 1.6.1 and a new git-1.6.1-r1 ebuild which solves these warnings. Have a nice day.
Created attachment 178400 [details, diff] git-1.6.1-r1 ebuild
Created attachment 178402 [details, diff] noperl patch for git 1.6.1
Created attachment 178403 [details] git-1.6.1-r1 ebuild
Created attachment 178427 [details] git-1.6.1-r1 ebuild
Latest patch and ebuild work for me. Thanks!
*** Bug 254963 has been marked as a duplicate of this bug. ***
Latest patch and ebuild work for me. dev-util/git-1.6.1-r1 USE="bash-completion curl gtk iconv threads vim-syntax -cgi -cvs -doc -emacs -mozsha1 -perl (-ppcsha1) -subversion -tk -webdav -xinetd"
+1 Thank you, Bernd!
+1 - thanks, Bernd!
*** Bug 256303 has been marked as a duplicate of this bug. ***
A few hours ago git v1.6.1.1 was released [1] with a lot of improvements and bugfixes [2]. Therefore I will attach the git-1.6.1.1.ebuild and the 20090126-git-1.6.1.1-noperl.patch. Have a nice day. [1] http://www.git-scm.com/ [2] http://www.kernel.org/pub/software/scm/git/docs/RelNotes-1.6.1.1.txt
Created attachment 179756 [details, diff] noperl patch for git 1.6.1.1
Created attachment 179757 [details] git-1.6.1.1 ebuild
incvs. Thanks, I've just been busy with real life (moving house etc, see my .away)
*** Bug 256496 has been marked as a duplicate of this bug. ***
this patch will need updating for 1.6.2 also might I ask why the noperl patch applies when the perl use flag is enabled?
We apply the patch so that we know it always works. It adds an option to the Git build system, so this way we know it's safe as well.
