Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 254000 - Make vim module for >=bash-completion-20081218 depend on base module
Summary: Make vim module for >=bash-completion-20081218 depend on base module
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Shell Tools project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 265504
  Show dependency tree
 
Reported: 2009-01-06 19:17 UTC by Willie Wong
Modified: 2009-04-09 04:47 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Willie Wong 2009-01-06 19:17:18 UTC
The vim module for bash completion calls the _filedir() function which is only defined in the base module for >=bash-completion-20081218. (In earlier versions, the _filedir() function is not defined in a separate module.) If a user enables vim module but disables the base module, on the console, typing "vim <tab><tab>" results in a bash error about _filedir() being undefined. 

Reproducible: Always

Steps to Reproduce:
1.emerge bash-completion
2.eselect bashcomp disable --global base
3.eselect bashcomp enable --global vim
4.vim <tab><tab>

Actual Results:  
It shows
bash: filedir(): command not found

Expected Results:  
Lists all files and subdirectories in the current directory. 

I understand that there is an ELOG message when you emerge bash-completion that asks the user to enable the base module if he desires to use bash completion. But I feel that if the vim module explicitly depends on the base module to operate, it will be better (if it is possible) to have the action of enabling the vim module also enable the base module. 

Also, if the system administrator had globally enabled vim and base, but the user decides to turn off bash-completion by just disabling base, the behaviour does not fall back to the default bash tab completion, which is what should be expected given the wording of the ELOG. 

Somehow I feel that disabling/enabling base should disable/enable all parts of the bash-completion, not just the base functions and leaving the additional modules hanging.
Comment 1 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2009-02-17 17:46:42 UTC
I have no idea how this can be accomplished. I'll be thinking about it.
Comment 2 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2009-04-09 04:47:28 UTC
Fixed in v1.0 - you will have to "downgrade" to use it.