Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 253841 - sys-apps/openrc wpa_supplicant.sh should exit in case of failure
Summary: sys-apps/openrc wpa_supplicant.sh should exit in case of failure
Status: RESOLVED NEEDINFO
Alias: None
Product: Gentoo Hosted Projects
Classification: Unclassified
Component: OpenRC (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: OpenRC Team
URL:
Whiteboard: openrc:oldnet:wpa_supplicant
Keywords: Inclusion
Depends on:
Blocks:
 
Reported: 2009-01-05 12:51 UTC by Griz Inabnit
Modified: 2011-09-18 21:02 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Griz Inabnit 2009-01-05 12:51:12 UTC
Having issues getting my rt2500pci to connect led me to UberLord and during the debug process, he found a change he wanted in  /lib/rcscripts/net/wpa_supplicant.sh  for better management.



Reproducible: Always




the diff of our edited wpa_supplicant.sh to the one in baselayout now

--- /lib/rcscripts/net/wpa_supplicant.sh        2009-01-05 04:07:36.000000000 -0800
+++ /home/griz/temp/wpa_supplicant.sh   2007-10-23 15:59:26.000000000 -0700
@@ -325,7 +325,7 @@
                        --pidfile "/var/run/wpa_cli-${iface}.pid" \
                        -- -a"${actfile}" -p"${ctrl_dir}" -i"${iface}" \
                        -P"/var/run/wpa_cli-${iface}.pid" -B
-               eend "$?" && exit 0
+               eend "$?" || return 1
        fi

        eindent
Comment 1 Griz Inabnit 2009-01-05 12:55:27 UTC
Ignore the first posting of the diff as it's bass ackwards! :-(

328c328
<               eend "$?" || return 1
---
>               eend "$?" && exit 0


THIS ^ ^ ^  is the corrected diff  and my apologies!
Comment 2 William Hubbs gentoo-dev 2010-08-04 23:29:24 UTC
This request is for bl1, but can you  look at openrc's oldnet scripts
and look at carrying this forward?