Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 253777 - sys-apps/grep-2.5.3-r1 fails with nls disabled on Gentoo/FreeBSD.
Summary: sys-apps/grep-2.5.3-r1 fails with nls disabled on Gentoo/FreeBSD.
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All FreeBSD
: High minor (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-04 20:26 UTC by Javier Villavicencio (RETIRED)
Modified: 2010-03-23 21:11 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
grep-2.5.3-nls.patch (grep-2.5.3-nls.patch,1.65 KB, patch)
2009-01-04 20:28 UTC, Javier Villavicencio (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Javier Villavicencio (RETIRED) gentoo-dev 2009-01-04 20:26:16 UTC
The following error occurs with USE="-nls":

i686-gentoo-freebsd7.0-gcc  -O2 -march=k8 -pipe -o fgrep fgrep.o fsearch.o kwset.o ../lib/libgreputils.a
../lib/libgreputils.a(obstack.o): In function `print_and_abort':
obstack.c:(.text+0x305): undefined reference to `libintl_gettext'
collect2: ld returned 1 exit status
gmake[2]: *** [fgrep] Error 1

The patch grep-2.5.1a-nls.patch from the previous version (after a little update) fixes the problem.
Comment 1 Javier Villavicencio (RETIRED) gentoo-dev 2009-01-04 20:28:58 UTC
Created attachment 177394 [details, diff]
grep-2.5.3-nls.patch

Updated patch with the occurrences of HAVE_LIBINTL_H checked against ENABLE_NLS.
Comment 2 SpanKY gentoo-dev 2009-01-04 20:43:34 UTC
clean up the patch and it should be fine to commit

http://dev.gentoo.org/~vapier/clean-patches
Comment 3 Javier Villavicencio (RETIRED) gentoo-dev 2009-01-04 21:09:58 UTC
Comitted with a cleaned up patch. <3 scrub_patch btw.
Comment 4 Timothy Redaelli (RETIRED) gentoo-dev 2009-03-12 10:29:15 UTC
Please readd the nls patch in 2.5.4 version
Comment 5 SpanKY gentoo-dev 2010-03-23 21:11:01 UTC
seems Timothy re-added the patch a year ago ...