Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 253441 - sys-apps/xinetd-2.3.14: /etc/init.d/xinetd script incorrect start-stop-daemon command
Summary: sys-apps/xinetd-2.3.14: /etc/init.d/xinetd script incorrect start-stop-daemon...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-02 12:04 UTC by Ian Pickworth
Modified: 2009-01-02 20:39 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
xinetd.rc6.diff (xinetd.rc6.diff,400 bytes, patch)
2009-01-02 12:28 UTC, Lars Wendler (Polynomial-C) (RETIRED) 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Pickworth 2009-01-02 12:04:15 UTC 
I emerged sys-apps/xinetd into a newly built gentoo system, and get an error when starting the service:

ian2 ~ # /etc/init.d/xinetd start
 * Starting xinetd ...
/sbin/start-stop-daemon: --start needs --exec or --startas
Try `/sbin/start-stop-daemon --help' for more information. 


Reproducible: Always

Steps to Reproduce:
1. emerge sys-apps/xinetd
2. /etc/init.d/xinetd start


Actual Results:  
 * Starting xinetd ...
/sbin/start-stop-daemon: --start needs --exec or --startas
Try `/sbin/start-stop-daemon --help' for more information.

Expected Results:  
 * Starting xinetd ...                                                    [ ok ]


Examining the start clause in /etc/init.d/xinetd I see the following line:

        start-stop-daemon --start --pidfile /var/run/xinetd.pid -- \
                xinetd -pidfile /var/run/xinetd.pid ${XINETD_OPTS}

The command is incorrect. I modified it to this

        start-stop-daemon --start --exec /usr/sbin/xinetd -- \
                -pidfile /var/run/xinetd.pid ${XINETD_OPTS}

and it worked.
Comment 1 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2009-01-02 12:25:58 UTC 
This is a problem with /sbin/start-stop-daemon from sys-apps/baselayout-1*

On a box with sys-apps/baselayout-2* and start-stop-daemon from sys-apps/openrc-0.4.1-r1, xinetd gets started without any problems.

I tested the changes Ian suggested with baselayout-2*/openrc-0.4.1-r1 as well and with his changes, the init script works with start-stop-daemon from both packages.

Reassigning to base-system herd.
Comment 2 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2009-01-02 12:28:43 UTC 
Created attachment 177089 [details, diff]
xinetd.rc6.diff

Ian's suggestion in handy patch form :)
Comment 3 David Krider 2009-01-02 15:48:46 UTC 
I have two amd64 systems, one had the problem, one didn't. I noticed on the old one (that did NOT have the problem) that there was a note in /etc/init.d/xinetd about a workaround for bug 25754. That bug was interesting, but for a much older version of baselayout. I copied that file over to the new machine, and it worked. What bothers me is that both systems are at the same revision of xinetd, but this got changed mid-revision. There's been no version bump. I tried this specific fix; it works fine. So my plea here is to get this bumped with the fix. (I don't want to go to baselayout-2 until it hits stable.)