Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 253335 - x11-misc/notification-daemon-xfce misses dependency on libnotify
Summary: x11-misc/notification-daemon-xfce misses dependency on libnotify
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: XFCE Team
URL:
Whiteboard:
Keywords:
Depends on: 253334
Blocks:
  Show dependency tree
 
Reported: 2009-01-01 09:20 UTC by Peter Volkov (RETIRED)
Modified: 2009-01-18 15:34 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Volkov (RETIRED) gentoo-dev 2009-01-01 09:20:32 UTC
It looks like  x11-misc/notification-daemon-xfce misses dependency on libnotify:
configure.in:

XDT_CHECK_OPTIONAL_PACKAGE([LIBNOTIFY], [libnotify], [0.4.0],
                           [settings-preview], [libnotify], [yes])


localhost notification-daemon-xfce-0.3.7 # grep -r notify.h .
./src/settings/main.c:#include <libnotify/notify.h>
[snip]

It's optional but anyway automatic dependencies are bad so either USE flag or just DEPEND should fix that. Since I don't see why libnotify depends on x11-misc/notification-daemon-xfce (bug 253334) I think it's simpler just to add DEPEND.
Comment 1 Christoph Mende (RETIRED) gentoo-dev 2009-01-10 17:27:31 UTC
well, if we add the dependency to notification-daemon-xfce, we'll get a loop, if we remove the notification-daemon-xfce dependency from libnotify, we'll pull in notification-daemon when depending on libnotify which means nobody will ever use notification-daemon-xfce. if we change dependencies for USE=libnotify, we'd have to change it to || ( libnotify notification-daemon-xfce ) for every ebuild using that USE flag, which seems... overkill. we could also pass --disable-settings-preview to econf to remove that dependency. considering that you actually do need libnotify to use notification-daemon-xfce, I'd say this automagic dependency doesn't hurt.
I'm not sure if the notification daemons are needed for building for libnotify, if not we could move them to PDEPEND
Comment 2 Peter Volkov (RETIRED) gentoo-dev 2009-01-18 13:31:20 UTC
Christoph, any dependencies on notification daemons were removed from libnotify. So, please, add this dependency now.
Comment 3 Christoph Mende (RETIRED) gentoo-dev 2009-01-18 15:34:10 UTC
+  18 Jan 2009; Christoph Mende <angelos@gentoo.org>
+  notification-daemon-xfce-0.3.7.ebuild:
+  Added libnotify dependency, bug 253335