Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 253116 - Version bump for app-emacs/ess-5.3.10
Summary: Version bump for app-emacs/ess-5.3.10
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Emacs project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-30 11:04 UTC by Neil
Modified: 2009-01-14 09:22 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Neil 2008-12-30 11:04:31 UTC
New version of app-emacs/ess-5.3.10 available (see https://stat.ethz.ch/pipermail/ess-help/2008-December/005034.html )

Straight forward version bump works fine

Reproducible: Always

Steps to Reproduce:
1. cp /usr/portage/app-emacs/ess-5.3.8.ebuild /usr/local/portage/app-emacs/ess/ess-5.3.10.ebuild
2. ebuild /usr/local/portage/app-emacs/ess/ess-5.3.10.ebuild digest
3. emerge -u app-emacs/ess

Actual Results:  
Installs fine

Expected Results:  
Installs fine
Comment 1 Ulrich Müller gentoo-dev 2008-12-30 23:12:42 UTC
Thanks, bumped to 5.3.10.

> Straight forward version bump works fine

Almost. ;-) There are some changes with respect to installation of the documentation. See the diff between the 5.3.8 and 5.3.10 ebuilds for details.

Also, the package's build system (doc/Makefile, target "install-other-docs") fails to create the $(DOCDIR)/html and $(DOCDIR)/refcard directories:

cp -p html/ess.html html/readme.html /var/tmp/portage/app-emacs/ess-5.3.10/image//usr/share/doc/ess-5.3.10/html
cp: target `/var/tmp/portage/app-emacs/ess-5.3.10/image//usr/share/doc/ess-5.3.10/html' is not a directory
make[1]: *** [install-other-docs] Error 1

Neil: I've added a workaround for this to the ebuild, but may I ask you to report this problem upstream?
Comment 2 Neil 2008-12-30 23:42:00 UTC
(In reply to comment #1)
> Thanks, bumped to 5.3.10.
> 
> > Straight forward version bump works fine
> 
> Almost. ;-) There are some changes with respect to installation of the
> documentation. See the diff between the 5.3.8 and 5.3.10 ebuilds for details.
> 

Ah, apologies, I was aware of this as changes to the README have been discussed on the mailing list (starts at https://stat.ethz.ch/pipermail/ess-help/2008-December/004977.html with various other comments from maintainers and input in the archives).  Possibly stems from the person who made the changes not having much experience in Makefile (as they admit in their post).

> Also, the package's build system (doc/Makefile, target "install-other-docs")
> fails to create the $(DOCDIR)/html and $(DOCDIR)/refcard directories:
> 
> cp -p html/ess.html html/readme.html
> /var/tmp/portage/app-emacs/ess-5.3.10/image//usr/share/doc/ess-5.3.10/html
> cp: target
> `/var/tmp/portage/app-emacs/ess-5.3.10/image//usr/share/doc/ess-5.3.10/html' is
> not a directory
> make[1]: *** [install-other-docs] Error 1
> 
> Neil: I've added a workaround for this to the ebuild, but may I ask you to
> report this problem upstream?

Again apologies, was doing this remotely over ssh and left it running whilst I got on with work, blithely assumed that because the emerge completed succesfully that everything was ok.  Not a problem though, will let them know and feedback here if there is anything of significance (although I'd imagine it will likely just be added to the next release).
Comment 3 Ulrich Müller gentoo-dev 2008-12-31 00:03:49 UTC
(In reply to comment #2)
> Again apologies, was doing this remotely over ssh and left it running whilst
> I got on with work, blithely assumed that because the emerge completed
> succesfully that everything was ok.

"make install" continues after the error and even returns a good status. This should be fixed, too. (The reason is that the main Makefile uses a "for" loop for the subdirectories, which ignores the return status of the sub-makes.)

> Not a problem though, will let them know and feedback here if there is
> anything of significance (although I'd imagine it will likely just be added
> to the next release).

That would be fine. No need to do anything for 5.3.10, but we shouldn't keep the workaround forever.
Comment 4 Neil 2009-01-14 08:53:52 UTC
(In reply to comment #3)

Bit late in replying, but this is now sorted in CVS.

See thread at https://stat.ethz.ch/pipermail/ess-help/2008-December/005063.html
Comment 5 Ulrich Müller gentoo-dev 2009-01-14 09:22:40 UTC
> Bit late in replying, but this is now sorted in CVS.

Thanks for reporting it upstream.

However, it looks like the following problem is still present in <http://svn.r-project.org/ESS/trunk/Makefile>:

(In reply to comment #3)
> "make install" continues after the error and even returns a good status. This
> should be fixed, too. (The reason is that the main Makefile uses a "for" loop
> for the subdirectories, which ignores the return status of the sub-makes.)