Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 252983 - [kde-testing] kde-base/kopete-4.1.85 jingle support
Summary: [kde-testing] kde-base/kopete-4.1.85 jingle support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] KDE (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords: InOverlay
Depends on:
Blocks:
 
Reported: 2008-12-29 12:17 UTC by Dennis Schridde
Modified: 2009-01-02 16:57 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Proposed patch (0001-Make-jingle-support-configurable.patch,3.25 KB, patch)
2008-12-29 12:20 UTC, Dennis Schridde
Details | Diff
Proposed patch (0002-Make-jingle-support-configurable.patch,3.24 KB, patch)
2008-12-29 12:23 UTC, Dennis Schridde
Details | Diff
Addition to the patch (0003-libjingle-is-not-needed-for-this-implementation-of-t.patch,1.93 KB, patch)
2008-12-30 01:01 UTC, Dennis Schridde
Details | Diff
Updated patch for 4.1.87 (0002-Make-jingle-support-configurable-4.1.87.patch,2.04 KB, patch)
2009-01-02 16:43 UTC, Dennis Schridde
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dennis Schridde 2008-12-29 12:17:03 UTC
The attached patch makes kopete's jingle support configurable via useflags (previously automatically enable if the necessary libraries were present).

Reproducible: Always
Comment 1 Dennis Schridde 2008-12-29 12:20:46 UTC
Created attachment 176736 [details, diff]
Proposed patch
Comment 2 Dennis Schridde 2008-12-29 12:23:12 UTC
Created attachment 176737 [details, diff]
Proposed patch
Comment 3 Dennis Schridde 2008-12-30 01:01:38 UTC
Created attachment 176815 [details, diff]
Addition to the patch

This patch removes the dependency on libjingle again (apply it on top of 0002*), since the legacy libjingle is not compliant to the newer revisions of the Jingle patch, and thus no longer used.
Comment 4 Tomáš Chvátal (RETIRED) gentoo-dev 2008-12-30 01:51:36 UTC
Hi,
we personaly hate the state of kopete ebuild, dont you want to clean it up completely? it would be nice of you and i am pretty sure i would use your patches because nobody wants to play with it :]

this patch also looks fine, so i would just wait for your answer about complete cleanup and if you say no i will add this to kde-testing
Comment 5 Dennis Schridde 2008-12-30 01:57:02 UTC
I can have a look at it later, but now I do not have the time. Thus you are better of taking these patches for now, and I may look into a rewrite in a few weeks.
Comment 6 Dennis Schridde 2009-01-02 16:43:26 UTC
Created attachment 177117 [details, diff]
Updated patch for 4.1.87