Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 252811 - net-misc/ipv6calc-0.72.0 with USE="-geoip" fails due to broken makefiles
Summary: net-misc/ipv6calc-0.72.0 with USE="-geoip" fails due to broken makefiles
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal
Assignee: Peter Volkov (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-28 12:48 UTC by Mike Auty (RETIRED)
Modified: 2008-12-28 20:31 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Auty (RETIRED) gentoo-dev 2008-12-28 12:48:33 UTC
Hiya,

Just a quick note that the Makefiles for ipv6calc-0.72.0 always include the GEOIP libraries, whether GeoIP's been enabled or not:

i686-pc-linux-gnu-gcc -o ipv6calc ipv6calc.o showinfo.o ../md5/md5.o -lipv6calc -L../lib/ -lGeoIP -Wl,--as-needed
/usr/lib/gcc/i686-pc-linux-gnu/4.3.2/../../../../i686-pc-linux-gnu/bin/ld: cannot find -lGeoIP
collect2: ld returned 1 exit status
make[1]: *** [ipv6calc] Error 1

Whilst it does check for GeoIP in configure.in, the ipv6calc/Makefile.in seems to always include @GEOIP_LIBS@ every time.

Also unfortunately, it includes the libraries as part of LDFLAGS rather than LIBS or something similar, so there's probably some Makefile QA love needed, but I haven't seen any "--as-needed" issues yet.
Comment 1 Peter Volkov (RETIRED) gentoo-dev 2008-12-28 18:22:41 UTC
Ah, true. I completely forgot about LIBS/LDFLAGS issue in this release. Hopefully I'll fix it soon. Thank you for report Mike.
Comment 2 Peter Volkov (RETIRED) gentoo-dev 2008-12-28 20:31:21 UTC
Thank you Mike another time. Now fixed in the tree.

Build system requires much more cleanup there, but even if I get to this work, I'll post results upstream only...  But we'll see if I manage to find time.