Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 252720 - nvidia-driver.eclass messages use ewarn not elog
Summary: nvidia-driver.eclass messages use ewarn not elog
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Ricardo Mendoza (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-27 17:30 UTC by Richard Ash
Modified: 2009-01-29 22:21 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Ash 2008-12-27 17:30:53 UTC
All the text output by nvidia-driver-check-warning() in nvidia-driver.eclass is processed through ewarn. This produces a nice big warning when the ebuild starts to install, but nothing in /var/log/portage/ or in the elog digest printed when the emerge run terminates.

As a result, anyone who isn't sat there watching the emerge happen (or doesn't catch the flying text quick enough) misses the warning, reads the other elog messages (from the ebuild) about removing the kernel module and so on, and assumes that is all there is to know about the ebuild. This makes tracking down the actual problem (that nvidia have quietly declared your graphics card legacy) rather harder than it should be, given the excellent diagnostics in the eclass.

I (now) realise that I can configure getting ewarn messages into the portage logs if I set them up in /etc/make.conf, however the default set-up still seems to be that only elog is logged (which does have some log it to it). Maybe just a single line elog noting that the warning has been issued?
Comment 1 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2008-12-29 00:33:50 UTC
Assigning to maintainer to decide.
Comment 2 Tony Vroon (RETIRED) gentoo-dev 2008-12-29 02:06:34 UTC
I no longer maintain nvidia-drivers or anything related to it (don't have the relevant hardware anymore). darkside, ricmm, please update any metadata.xml files that say otherwise. Thank you.
Comment 3 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2008-12-29 02:41:18 UTC
%% head /usr/portage/eclass/nvidia-driver.eclass 
# Copyright 1999-2008 Gentoo Foundation
# Distributed under the terms of the GNU General Public License v2
# $Header: /var/cvsroot/gentoo-x86/eclass/nvidia-driver.eclass,v 1.14 2008/07/17 12:20:49 chainsaw Exp $

# @ECLASS: nvidia-driver.eclass
# @MAINTAINER: <chainsaw@gentoo.org>
#
# Original Author: Doug Goldstein <cardoe@gentoo.org>
# @BLURB: Provide useful messages for nvidia-drivers based on currently installed Nvidia card
# @DESCRIPTION:
Comment 4 Doug Goldstein (RETIRED) gentoo-dev 2009-01-29 22:21:50 UTC
The default setting for messages that are to be logged are as follows:
PORTAGE_ELOG_CLASSES="log warn error"
as per /etc/make.globals

The reason elog was created different from einfo is that there were a lot of messages that were einfo'd and weren't worth being logged constantly.

That being said, the message provided by the eclass is certainly a warning because you're very likely doing something wrong that will result in unexpected results. The messages should be at the ewarn level.

The current stable Portage (and the last stable 2.1.4.x) will print these messages out at the time they are executed and at the end with the default configuration. If you're not seeing them, then you have configured the level of logging you'd like and have excluded a very important set of messages.