Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 251905 - biew 5.7.0 ebuild
Summary: biew 5.7.0 ebuild
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal
Assignee: Wormo (RETIRED)
URL:
Whiteboard:
Keywords:
: 251849 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-12-21 17:51 UTC by Andrej Gelenberg
Modified: 2008-12-26 08:08 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
biew-5.7.0.ebuild (biew-5.7.0.ebuild,984 bytes, text/plain)
2008-12-21 17:52 UTC, Andrej Gelenberg
Details
makefile_570.patch (makefile_570.patch,1.44 KB, text/plain)
2008-12-21 17:53 UTC, Andrej Gelenberg
Details
fix gpm dependencies (biew-5.7.0.ebuild.patch,672 bytes, text/plain)
2008-12-23 15:08 UTC, Andrej Gelenberg
Details
Allow gpm option to be set on configure command-line rather than auto-detected (biew-570-configure-gpm.patch,438 bytes, patch)
2008-12-24 21:55 UTC, Wormo (RETIRED)
Details | Diff
fix gpm use flag behaver (biew-5.7.0.ebuild-r2.patch,440 bytes, text/plain)
2008-12-25 16:56 UTC, Andrej Gelenberg
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrej Gelenberg 2008-12-21 17:51:34 UTC
Hier is my ebuild for biew 5.7.0. Please test it.

Reproducible: Always

Steps to Reproduce:
Comment 1 Andrej Gelenberg 2008-12-21 17:52:47 UTC
Created attachment 176059 [details]
biew-5.7.0.ebuild
Comment 2 Andrej Gelenberg 2008-12-21 17:53:27 UTC
Created attachment 176061 [details]
makefile_570.patch

make it work with sandbox
Comment 3 Andrej Gelenberg 2008-12-21 17:57:01 UTC
*** Bug 251849 has been marked as a duplicate of this bug. ***
Comment 4 Wormo (RETIRED) gentoo-dev 2008-12-23 08:04:46 UTC
Thanks for submitting your ebuild.

I notice your ebuild leaves out the gpm support from 5.6.2-r1 ebuild; was that an oversight, or on purpose?
Comment 5 Andrej Gelenberg 2008-12-23 15:08:07 UTC
Created attachment 176220 [details]
fix gpm dependencies 

I have forgotten about gpm. Biew configure-script detect gpm self. Biew build compile 32-bit binary, and also need biew on amd64 app-emulation/emul-linux-x86-baselibs for runtime, but for compilation sys-libs/gpm too (headers).
Comment 6 Wormo (RETIRED) gentoo-dev 2008-12-24 18:53:00 UTC
You have to be careful when packages want to automatically use dependencies that happen to be installed; it is a packaging bug if you let them do that. 

Consider the following sequence of events:
* user has gpm library installed, but gpm useflag is currently off
* user installs biew ebuild that auto-detects gpm and links to it without package manager realizing gpm is a dependency (since useflag is off)
* user uninstalls some other package that originally pulled in gpm and 'emerge depclean' removes gpm
* biew is now broken, because it secretly linked against gpm library which got uninstalled!

Check out src_unpack section in biew-5.6.2-r1.ebuild for an example on how to handle this.
Comment 7 Wormo (RETIRED) gentoo-dev 2008-12-24 21:41:27 UTC
Hm, the build now has a custom configure script, so that will need to be patched to thwart the gpm auto-detection. I'll attach my candidate patch, which needs ebuild support to go with it (basically calling econf with _gpm=yes or _gpm=no according to useflag).

Also, it seems that the ncurses and slang libraries aren't used anymore for linux platform, so those useflags and dependencies can go away.
Comment 8 Wormo (RETIRED) gentoo-dev 2008-12-24 21:55:55 UTC
Created attachment 176323 [details, diff]
Allow gpm option to be set on configure command-line rather than auto-detected
Comment 9 Andrej Gelenberg 2008-12-25 16:56:20 UTC
Created attachment 176360 [details]
fix gpm use flag behaver

For me work it now properly. When no gpm-use-flag there, it not linked against gpm.
Comment 10 Wormo (RETIRED) gentoo-dev 2008-12-26 08:08:26 UTC
biew-5.7.0 just committed to cvs, thanks for your help.