Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 251394 - net-analyzer/zabbix should change USE flag sqlite3 to sqlite
Summary: net-analyzer/zabbix should change USE flag sqlite3 to sqlite
Status: RESOLVED TEST-REQUEST
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Matthew Marlowe (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 249418
  Show dependency tree
 
Reported: 2008-12-18 00:43 UTC by Henrique Rodrigues
Modified: 2012-03-20 18:52 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Henrique Rodrigues 2008-12-18 00:43:59 UTC
sqlite 2 should be deprecated in favor of sqlite 3, so the "sqlite3" use flag
should be changed to "sqlite".


Reproducible: Always
Comment 1 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2008-12-18 13:49:09 UTC
Reassigning to maintainer.
Comment 2 Johan Bergström 2010-08-30 12:20:53 UTC
It doesn't look like it uses sqlite2 anymore, use flag is still called sqlite3 though.
Comment 3 Matthew Marlowe (RETIRED) gentoo-dev 2011-08-26 04:46:06 UTC
This bug seems to have been open for several years and the current implementation uses sqlite3 flag --- which seems to be used in at least 1 other ebuild.  Is sqlite3 flag actually depreciated in favor of sqlite flag?
Comment 4 Pacho Ramos gentoo-dev 2012-03-19 09:44:43 UTC
This is the last bug blocking 249418
Comment 5 Pacho Ramos gentoo-dev 2012-03-19 09:54:05 UTC
+  19 Mar 2012; Pacho Ramos <pacho@gentoo.org> zabbix-1.8.10-r1.ebuild,
+  zabbix-1.9.5-r1.ebuild:
+  Move from sqlite3 USE flag to sqlite, bug #251394 (fixed with Patrick
+  permission).
+
Comment 6 Alexander Vershilov (RETIRED) gentoo-dev 2012-03-20 08:32:52 UTC
There is another problem in this ebuild, you forgot to fix USE test, plz
apply. Or maybe I would be metter to use REQUIRED USE?



After change use flags in #251394 zabbix it's not possible to install zabbix.

reported by: greek_31 
patch by: Alexander Vershilov (qnikst)

--- a/zabbix-1.8.10-r1.ebuild
+++ b/zabbix-1.8.10-r1.ebuild
@@ -52,7 +52,7 @@ src_prepare() {
 
 pkg_setup() {
        if use server || use proxy ; then
-               local dbnum dbtypes="mysql oracle postgres sqlite3" dbtype
+               local dbnum dbtypes="mysql oracle postgres sqlite" dbtype
                declare -i dbnum=0
                for dbtype in ${dbtypes}; do
                        use ${dbtype} && let dbnum++
Comment 7 Matthew Marlowe (RETIRED) gentoo-dev 2012-03-20 10:59:03 UTC
Change should have resulted in a bump to r2 for 1.8.10, r1 was stable and the recommended release for users....it appears change might have broken ebuild, please bump and at least test build in future.  

I don't use sqlite so can not test, but it appears the patch uploaded looks correct.

I'll apply and bump to r2.
Comment 8 Matthew Marlowe (RETIRED) gentoo-dev 2012-03-20 11:59:36 UTC
*zabbix-1.8.10-r2 (20 Mar 2012)

  20 Mar 2012; Matthew Marlowe <mattm@gentoo.org> zabbix-1.8.10-r1.ebuild,
  +zabbix-1.8.10-r2.ebuild, -zabbix-1.9.5-r1.ebuild:
  Reverted non maintainer commit that might have broken only stable release,
  moved changes to new r2 bump, applied user supplied patch to fix changes,
  marked new bump testing, removed obsolete alpha release

Putting bug in test-request status to ensure that it builds/runs for sqlite users (I don't use sqlite here).
Comment 9 Pacho Ramos gentoo-dev 2012-03-20 12:07:50 UTC
Oops, sorry a lot
Comment 10 Alexander Vershilov (RETIRED) gentoo-dev 2012-03-20 12:12:41 UTC
User who has reported this error on forum says that everything works (with patch),
I asked him to test new "official" ebuild and report to bugzilla for forum.

I'll report when he will test again.

Thanks.
Comment 11 Vlasov Vitaly 2012-03-20 13:12:10 UTC
I found this error.
I have zabbix proxy with sqlite db.
Before patch:
USE="agent proxy snmp sqlite ssh" emerge -pv zabbix
(i also tried USE="agent proxy snmp sqlite sqlite3 ssh" and USE="agent proxy snmp sqlite3 ssh")
[ebuild   R    ] net-analyzer/zabbix-1.8.10-r1  USE="agent proxy snmp sqlite%* ssh -curl -frontend -ipv6 -jabber -ldap -mysql -openipmi -oracle -postgres -server (-sqlite3%*)" 0
emerge zabbix
* QA Notice: USE Flag 'sqlite3' not in IUSE for net-analyzer/zabbix-1.8.10-r1
 * 
 * Select exactly one database type out of these: mysql oracle postgres sqlite3
 * 
 * ERROR: net-analyzer/zabbix-1.8.10-r1 failed (setup phase):
 *   No database type selected.

After applying the patch with flags "proxy agent sqlite ssh" zabbix was merged. Now zabbix proxy is working.