Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 251286 - Bugzilla produces invalid patch files out of certain attached bzr bundles
Summary: Bugzilla produces invalid patch files out of certain attached bzr bundles
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Infrastructure
Classification: Unclassified
Component: Bugzilla (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Bugzilla Admins
URL: http://bugs.gentoo.org/show_bug.cgi?i...
Whiteboard:
Keywords:
: 388017 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-12-17 08:17 UTC by Serkan Kaba (RETIRED)
Modified: 2018-09-30 07:09 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Serkan Kaba (RETIRED) gentoo-dev 2008-12-17 08:17:51 UTC
This happens if the encrypted bundle part has a line starting with + (maybe - as well) Bundle is already in tree[1] and applies succesfully.

See attachment in the URL.

1: http://tinyurl.com/5qmxhp
Comment 1 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2008-12-17 23:59:29 UTC
What's invalid with it? Viewing the attachment shows it to be identical to the tree link
Comment 2 Serkan Kaba (RETIRED) gentoo-dev 2008-12-18 19:14:15 UTC
The last addition line is extra produced. (See raw comment)
Comment 3 Peter Volkov (RETIRED) gentoo-dev 2008-12-27 08:40:49 UTC
Serkan, I've downloaded both:
http://tinyurl.com/5qmxhp
and
http://bugs.gentoo.org/attachment.cgi?id=173533&action=view
and they are identical.
Also they are identical with patch commited in the tree. Could you provide step by step instruction about how to reproduce this problem?
Comment 4 Michael Haubenwallner (RETIRED) gentoo-dev 2009-02-23 15:21:09 UTC
A somewhat-similar-sounding problem showing attachment#182889 [details, diff], which is an unidiff against an unidiff patchfile.

It starts with the right side of "Diff" missing the "+" lines:
http://bugs.gentoo.org/attachment.cgi?id=182889&action=diff

Expected is to get the same content when doing either "View" or "Raw Unified":
http://bugs.gentoo.org/attachment.cgi?id=182889
http://bugs.gentoo.org/attachment.cgi?id=182889&action=diff&context=patch&collapsed=&headers=1&format=raw

Should I create a separate bug for this?
Comment 5 Alex Legler (RETIRED) archtester gentoo-dev Security 2011-10-21 17:53:06 UTC
*** Bug 388017 has been marked as a duplicate of this bug. ***
Comment 6 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-09-30 07:09:21 UTC
As for mishandling of bzr patches, I think this is something to be handled upstream.  The 'diff' feature is not really crucial to our use of Bugzilla, and it exhibiting weird behavior with non-standard patch formats is not something we should concern ourselves with.

As for the other issue reported, I can't really reproduce.  The linked 'diff' seems to be correct.