Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 250884 - Unneeded seds and includes in mozilla products
Summary: Unneeded seds and includes in mozilla products
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-14 02:11 UTC by Jory A. Pratt
Modified: 2009-10-30 04:01 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jory A. Pratt gentoo-dev 2008-12-14 02:11:06 UTC
CPPFLAGS="${CPPFLAGS} -DARON_WAS_HERE" \

	# It would be great if we could pass these in via CPPFLAGS or CFLAGS prior
	# to econf, but the quotes cause configure to fail.
	sed -i -e \
		's|-DARON_WAS_HERE|-DGENTOO_NSPLUGINS_DIR=\\\"/usr/'"$(get_libdir)"'/nsplugins\\\" -DGENTOO_NSBROWSER_PLUGINS_DIR=\\\"/usr/'"$(get_libdir)"'/nsbrowser/plugins\\\"|' \
		"${S}"/config/autoconf.mk \
		"${S}"/toolkit/content/buildconfig.html

This should all be removed as it is redundant and has always been. I stated to kloeri back before his retirement and he never fixed it.

only line that needs to remain would be 

	CPPFLAGS="${CPPFLAGS} -DARON_WAS_HERE" \

but modified as followed :

	CPPFLAGS="${CPPFLAGS}" \


The path is already included when the stub is created by mozilla-launcher.eclass
Comment 1 Jory A. Pratt gentoo-dev 2009-05-12 02:32:33 UTC
anyone care to deal with this trivial bug? This has been open for 5 months and not even a single comment from a dev.
Comment 2 Jory A. Pratt gentoo-dev 2009-10-30 04:01:35 UTC
Most of this has been fixed in current ~arch, any ebuilds still using unneeded seds will be fixed as they are reviewed.