Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 250383 - sys-process/lsof-4.81-r2 fails to build on freebsd (recursive make with gnumake issue)
Summary: sys-process/lsof-4.81-r2 fails to build on freebsd (recursive make with gnuma...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All FreeBSD
: High normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-09 13:21 UTC by Alexis Ballier
Modified: 2008-12-10 10:44 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexis Ballier gentoo-dev 2008-12-09 13:21:36 UTC
It calls make directly for a recursive make call what causes issues for us as we're using gnu make by default.

Trivial fix:

--- lsof_4.81/lsof_4.81_src/dialects/freebsd/Makefile.old	2008-12-09 12:56:40 +0000
+++ lsof_4.81/lsof_4.81_src/dialects/freebsd/Makefile	2008-12-09 12:56:48 +0000
@@ -129,7 +129,7 @@
 
 dnode2.o:	dzfs.h dnode2.c
 		@if [ -f ./Makefile.zfs ]; then \
-		    make -f Makefile.zfs dnode2.o; \
+		    ${MAKE} -f Makefile.zfs dnode2.o; \
 		else \
 		    echo "${CC} ${CFLAGS} -c dnode2.c"; \
 		    ${CC} ${CFLAGS} -c dnode2.c; \


I've already mailed it upstream as noted in the bug report section of the readme, now the question is: would you mind if i apply it once i have a (positive) answer from upstream?
Comment 1 SpanKY gentoo-dev 2008-12-09 16:54:28 UTC
add proper header info and it should be fine to commit

http://dev.gentoo.org/~vapier/clean-patches
Comment 2 Alexis Ballier gentoo-dev 2008-12-10 10:44:08 UTC
(In reply to comment #1)
> add proper header info and it should be fine to commit
> 
> http://dev.gentoo.org/~vapier/clean-patches

info added and committed.