250232 – [PATCH] dev-libs/fcgi: iostream::underflow problem in library

Bug 250232 - [PATCH] dev-libs/fcgi: iostream::underflow problem in library

Summary: [PATCH] dev-libs/fcgi: iostream::underflow problem in library

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	Hans de Graaff

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2008-12-07 23:35 UTC by Derrick
Modified:	2008-12-08 21:25 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
new ebuild incorporating iostream::underflow patch (fcgi-2.4.0-r3[1].ebuild,1.25 KB, text/plain) 2008-12-07 23:38 UTC, Derrick	Details
iostream::underflow patch (fcgi-2.4.0-iostream-underflow[1].patch,28.10 KB, text/plain) 2008-12-07 23:40 UTC, Derrick	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Derrick 2008-12-07 23:35:14 UTC

There is a known issue in libfcgi that has been fixed for ages in 2.4.1-SNAP-0311112127. (See http://www.fastcgi.com/dist/fcgi-2.4.1-SNAP-0311112127.tar.gz)

As noted in the README,

 *) Fix fcgi_streambuf::underflow() such that when there is no buffer
    the character isn't removed.  AIDA Shinra <shinra@j10n.org>
 *) Add attach() and detach() support.


Reproducible: Always

Steps to Reproduce:
1. Compile a FastCGI that uses iostream.
2. Read from the input stream.

Actual Results:  
Missing characters.

Expected Results:  
No missing characters.

Comment 1 Derrick 2008-12-07 23:38:08 UTC

Created attachment 174615 [details]
new ebuild incorporating iostream::underflow patch

Comment 2 Derrick 2008-12-07 23:40:03 UTC

Created attachment 174617 [details]
iostream::underflow patch

A diff between http://www.fastcgi.com/dist/fcgi-2.4.0.tar.gz and http://www.fastcgi.com/dist/fcgi-2.4.1-SNAP-0311112127.tar.gz

Comment 3 Wormo (RETIRED) gentoo-dev

2008-12-08 01:54:27 UTC

Thanks for submitting this fix! Assigning to maintainer.

Comment 4 Hans de Graaff gentoo-dev

2008-12-08 20:57:30 UTC

I think it will be more transparent to just add the "new" SNAP version to portage instead of patching the 2.4.0 version, but that needs a bit of work due to the weird upstream version number.

Comment 5 Hans de Graaff gentoo-dev

2008-12-08 21:25:18 UTC

I've just added fcgi-2.4.1-pre-0311112127 to CVS.