After the upgrade from media-sound/banshee-1.4.1 to media-sound/banshee-1.4.1-r1, Banshee will no longer import FLAC files from my library. Banshee will play the FLAC files that are already there but will not import any new ones. It will still import MP3 files. Running banshee in debug mode says this for every FLAC file on import: [Error 13:13:38.127] /home/njdoyle/Music/flac/Aphex Twin/(1995) I Care Because You Do/01 Acrid Avid Jam Shred.flac - Object reference not set to an instance of an object [Debug 13:13:38.127] Full import exception: System.NullReferenceException: Object reference not set to an instance of an object at TagLib.Flac.File.GetTag (TagTypes type, Boolean create) [0x00000] at Banshee.Streaming.StreamTagger.IsCompilation (TagLib.File file) [0x00000] in /var/tmp/portage/media-sound/banshee-1.4.1-r1/work/banshee-1-1.4.1/src/Core/Banshee.Core/Banshee.Streaming/StreamTagger.cs:176 at Banshee.Streaming.StreamTagger.TrackInfoMerge (Banshee.Collection.TrackInfo track, TagLib.File file, Boolean preferTrackInfo) [0x000a3] in /var/tmp/portage/media-sound/banshee-1.4.1-r1/work/banshee-1-1.4.1/src/Core/Banshee.Core/Banshee.Streaming/StreamTagger.cs:133 at Banshee.Streaming.StreamTagger.TrackInfoMerge (Banshee.Collection.TrackInfo track, TagLib.File file) [0x00000] in /var/tmp/portage/media-sound/banshee-1.4.1-r1/work/banshee-1-1.4.1/src/Core/Banshee.Core/Banshee.Streaming/StreamTagger.cs:112 at Banshee.Collection.Database.DatabaseImportManager.ImportTrack (Banshee.Base.SafeUri uri) [0x00060] in /var/tmp/portage/media-sound/banshee-1.4.1-r1/work/banshee-1-1.4.1/src/Core/Banshee.Services/Banshee.Collection.Database/DatabaseImportManager.cs:176 Reproducible: Always Steps to Reproduce:
The problem persists with media-sound/banshee-1.4.1-r2. banshee-1.4.1-metadata-writefail.patch should be removed because it is simply broken. It breaks the ability to import files which makes Banshee useless. If I had to choose between playing my music at all or being able to tag it, I would obviously choose being able to play my music... On that note, the real problem should probably be fixed (here or upstream) so that you can import /and/ tag your music.
New patches over at http://bugzilla.gnome.org/show_bug.cgi?id=563283 . Says it should fix the problem. (trys with empty catches never makes me feel warm and fuzzy though) It would be nice to see these patches replace the broken ones in portage.
InCVS as -r3, try it out. Re-open on failure :-)
