250143 – MAKEOPTS clobbered: net-analyzer/symon-2.79-r5

Bug 250143 - MAKEOPTS clobbered: net-analyzer/symon-2.79-r5

Summary: MAKEOPTS clobbered: net-analyzer/symon-2.79-r5

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All All

Importance:	High QA (vote)
Assignee:	Tiago Cunha (RETIRED)

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2008-12-07 08:24 UTC by SpanKY
Modified:	2008-12-08 15:12 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description SpanKY gentoo-dev

2008-12-07 08:24:11 UTC

while you should be overriding -j# on `emake` lines, if you do want to tweak it
via MAKEOPTS, you should be appending, not clobbering the variable

broken code:
net-analyzer/symon/symon-2.79-r5.ebuild:60: MAKE=pmake MAKEOPTS= emake          \

Comment 1 Tiago Cunha (RETIRED) gentoo-dev

2008-12-07 19:55:52 UTC

I'm setting MAKEOPTS to an empty string, because net-analyzer/symon does not use GNU make. It avoids compilation errors when pmake encounters an unknown option (such as --load-average, which is only available in GNU make).

Comment 2 SpanKY gentoo-dev

2008-12-07 20:09:34 UTC

then why run `emake` at all ?  just run `pmake`

Comment 3 Tiago Cunha (RETIRED) gentoo-dev

2008-12-08 15:12:39 UTC

Indeed. Fixed in CVS. Thanks!