Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 250017 - sys-apps/baselayout 1.12.11.1 broken net init script does not ignore comments or parse modules correctly
Summary: sys-apps/baselayout 1.12.11.1 broken net init script does not ignore comments...
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] baselayout (show other bugs)
Hardware: x86 Linux
: High major (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-06 11:02 UTC by turtle
Modified: 2008-12-07 00:05 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description turtle 2008-12-06 11:02:38 UTC
Contents of conf.d.net file:
#lapcats /etc/conf.d/net
#Available modules: apipa arping tuntap bridge ccwgroup macchanger 
#macnet rename ifplugd iwconfig essidnet iptunnel ifconfig pppd 
#system dhcpcd ip6to4

config_eth0=( "dhcp" )
#config_eth0=( "192.168.0.11 netmask 255.255.255.0 broadcast 192.168.0.255" )
	modules_eth0=( "!apipa !arping !bridge !ccwgroup !cwgroup !ip6to4 !iptunnel !macchanger !macnet !pppd !rename !essidnet !system !tuntap" !iwconfig !wpa_supplicant" )	
	
	#modules_force_eth0=( "ifconfig" "dhcp" )
	#dhcp_eth0=( "-LI" )
	#routes_eth0=( "default gw commentedout 192.168.0.1" )

config_wlan0=( "dhcp" )
	#dhcp_wlan0=( "-L" )
	#did not help
	modules_wlan0=( "!apipa !arping !bridge !ccwgroup !cwgroup !ip6to4 !iptunnel  !macchanger !macnet !pppd !rename !netplugd !essidnet !system !tuntap !iwconfig" !wpa_supplicant" )
	#modules_force=( "iwconfig" "dhcpcd" "ifconfig" )
	
	#may help connect faster
	#no help
	#new prefered 
	preferred_aps_wlan0=( "lightning" "any" )
	#Old did not work preferred_aps_wlan0="lightning" 
	associate_order_wlan0="forcepreferred"

Now when I do a: 
/init.d/net.wlan0 restart
 * Caching service dependencies ...                                                            [ ok ]
 * Service net.wlan0 stopping
 * Stopping wlan0
 *   Loading networking modules for wlan0

******Here these should be ignored*****************
 *     modules: apipa arping tuntap bridge ccwgroup macchanger macnet rename iwconfig wpa_supplicant essidnet iptunnel ifconfig pppd system dhcpcd ip6to4
 *   Bringing down wlan0
 *     Stopping dhcpcd on wlan0 ...                                                            [ ok ]
 *     Shutting down wlan0 ...                                                                 [ ok ]
 * Service net.wlan0 stopped
 * Service net.wlan0 starting
 * Starting wlan0
 *   Loading networking modules for wlan0
 *     modules: apipa arping tuntap bridge ccwgroup macchanger macnet rename iwconfig essidnet iptunnel ifconfig pppd system dhcpcd ip6to4
 *       iwconfig provides wireless
 *       ifconfig provides interface
 *       pppd provides ppp
 *       dhcpcd provides dhcp
 *   Configuring wlan0 for MAC address 00:03:2F:38:16:78 ...                                   [ ok ]
 *   Configuring wireless network for wlan0
 *   Scanning for access points
 *     Found "lightning" at 00:09:5B:2B:79:F8 (managed, encrypted)
 *     Found "linksys" at 00:14:BF:45:8C:55 (managed)
 *     Found "Python" at 00:1C:10:B1:01:D5 (managed, encrypted)
 *   Connecting to "lightning" in managed mode (WEP enabled - open) ...                        [ ok ]
 *     wlan0 connected to ESSID "lightning" at 00:09:5B:2B:79:F8
 *     in managed mode on channel 11 (WEP enabled - open)
 *   Configuring wlan0 for ESSID "lightning" ...                                               [ ok ]
 *   Configuration not set for wlan0 - assuming DHCP
 *   Bringing up wlan0
 *     dhcp
 *       Running dhcpcd ...
wlan0: dhcpcd 4.0.2 starting
wlan0: broadcasting for a lease
wlan0: offered 192.168.0.3 from 192.168.0.1
******************this should not be happining*********************
wlan0: checking 192.168.0.3 is available on attached networks
wlan0: timed out                                                                               [ !! ]
 *     Trying fallback configuration
 *     192.168.0.3                                                                             [ ok ]
 *   Adding routes
 *     default via 192.168.0.3 ...                                                             [ ok ]
 * Service net.wlan0 started

lapcat conf.d # /etc/init.d/net.eth0 start
 * Service net.eth0 starting
 * Starting eth0
 *   Loading networking modules for eth0

************************the line that gw is in is commented out and does not contain anty module stuff*****************

 *     The module "gw" does not exist
 * ERROR:  net.eth0 failed to start
lapcat conf.d # /etc/init.d/net.eth0 start
 * Caching service dependencies ...                                                            [ ok ]
 * Service net.eth0 starting
 * Starting eth0
 *   Loading networking modules for eth0
/etc/init.d/net.eth0: line 364: ccwgroup_check_installed: command not found
/etc/init.d/net.eth0: line 364: ip6to4_check_installed: command not found
/etc/init.d/net.eth0: line 364: iptunnel_check_installed: command not found
/etc/init.d/net.eth0: line 364: macchanger_check_installed: command not found
/etc/init.d/net.eth0: line 364: macnet_check_installed: command not found
/etc/init.d/net.eth0: line 364: rename_check_installed: command not found
/etc/init.d/net.eth0: line 364: essidnet_check_installed: command not found
/etc/init.d/net.eth0: line 364: system_check_installed: command not found
 *     modules: apipa wpa_supplicant ifconfig dhcpcd
 *       wpa_supplicant provides wireless
 *       ifconfig provides interface
 *       dhcpcd provides dhcp
 *   wpa_supplicant_eth0 does not define a driver
 *   wpa_supplicant only works on wireless interfaces
 *   unless the -D wired option is specified
 *   Bringing up eth0
 *     dhcp
 *       Running dhcpcd ...
eth0: dhcpcd 4.0.2 starting
eth0: broadcasting for a lease
eth0: offered 192.168.0.10 from 192.168.0.1
eth0: checking 192.168.0.10 is available on attached networks
eth0: acknowledged 192.168.0.10 from 192.168.0.1
eth0: leased 192.168.0.10 for 259200 seconds                                                   [ ok ]
 *       eth0 received address 192.168.0.10/24
 * Service net.eth0 started
lapcat conf.d # esearch baselayout
[ Results for search key : baselayout ]
[ Applications found : 2 ]

*  sys-apps/baselayout
      Latest version available: 1.12.11.1
      Latest version installed: 1.12.11.1
      Size of downloaded files: [no/bad digest]
      Homepage:    http://www.gentoo.org/
      Description: Filesystem baselayout and init scripts
      License:     GPL-2

	



Reproducible: Always

Steps to Reproduce:
1.Compile in the modules listed above in a recent kernel
2.Try to get a network interface to start without loading them
3.try to comment something out of the net file and it will not be ignored
4.There is no way to stop the "checking IP is available on attached networks"



Expected Results:  
init script should ignore and thus not load modules with a ! and ignore lines that start with a #
Comment 1 Matthias Schwarzott gentoo-dev 2008-12-06 16:39:44 UTC
(In reply to comment #0)
>         modules_wlan0=( "!apipa !arping !bridge !ccwgroup !cwgroup !ip6to4
> !iptunnel  !macchanger !macnet !pppd !rename !netplugd !essidnet !system
> !tuntap !iwconfig" !wpa_supplicant" )
>         #modules_force=( "iwconfig" "dhcpcd" "ifconfig" )
It looks like you did array-syntax wrong in setting modules_wlan0. Every entry should be quoted itself, as you did in modules_force.
Comment 2 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2008-12-07 00:05:25 UTC
You have a dangling quotes in modules_eth0 and modules_wlan0, and thus it's being flunked as bash syntax:
>        modules_eth0=( "!apipa !arping !bridge !ccwgroup !cwgroup !ip6to4
>!iptunnel !macchanger !macnet !pppd !rename !essidnet !system !tuntap"
>!iwconfig !wpa_supplicant" )   
Notice that there are 3 double quotes. Same goes for modules_wlan0.
Turn syntax highlighting on in your editor, and it will stand out massively.