Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 249923 - net-misc/miniupnpd-20081009: miniupnpd-20081009-iptables_path.diff patch is wrong
Summary: net-misc/miniupnpd-20081009: miniupnpd-20081009-iptables_path.diff patch is w...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal
Assignee: Bjarke Istrup Pedersen (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-05 11:08 UTC by costhezz
Modified: 2008-12-07 00:58 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
solves problem (miniupnpd-20081009-iptables_path.diff,1.64 KB, patch)
2008-12-05 11:11 UTC, costhezz
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description costhezz 2008-12-05 11:08:45 UTC
miniupnpd-20081009-iptables_path.diff patch is wrong, it hasn't been updated,
epatch dies

Reproducible: Always

Steps to Reproduce:
emerge -av =net-misc/miniupnpd-20081009


Expected Results:  
patch & compile
Comment 1 costhezz 2008-12-05 11:11:26 UTC
Created attachment 174310 [details, diff]
solves problem
Comment 2 Wormo (RETIRED) gentoo-dev 2008-12-06 07:27:30 UTC
Aha, I see what happened -- it is a classic problem that can happen when checking patches into cvs... the patch has lines that trigger cvs keyword expansion, so cvs changes the patch as it is being checked in.

Thanks for reporting this issue, assigning to maintainer
Comment 3 Bjarke Istrup Pedersen (RETIRED) gentoo-dev 2008-12-06 20:18:19 UTC
I'll take a look at it, and try pushing it into the tree again and see if it works correctly this time.
Comment 4 Bjarke Istrup Pedersen (RETIRED) gentoo-dev 2008-12-07 00:44:59 UTC
No matter what I try, CVS insists on messing with the patch.
For now I'll leave it open until I find a solution.
Comment 5 Bjarke Istrup Pedersen (RETIRED) gentoo-dev 2008-12-07 00:58:14 UTC
Should be fixed now, seems like CVS had to be tweaked a bit to keep it away from messing with the patch.
Please test and see if it works now :)