Bug 249838 – media-sound/mp32ogg-0.11-r5: wrong warning

• Status: RESOLVED NEEDINFO
• Product: Gentoo Linux

[Description Bartosz Neuman 2008-12-04 20:01:57 UTC]

Use of --quality option always produce "MP3::Info didn't report the bitrate... weird. Corrupt MP3 file? Bug?" warning due to incorrect if / else structure.

Reproducible: Always

Steps to Reproduce:
1. Execute with --quality option
Actual Results:  
MP3::Info didn't report the bitrate... weird. Corrupt MP3 file? Bug?

Expected Results:  
(no warning)

Instead of:
        if (($userquality < -1) || ($userquality > 10)) {
            # Set quality adjacent to mp3 bitrate
            if($mp3bitrate ne "") {
                if($mp3bitrate > 256) {
                    $quality = 8;
                } elsif($mp3bitrate > 192) {
                    $quality = 7;
                } elsif($mp3bitrate > 128) {
                    $quality = 6;
                } else {
                    $quality = 5;
                }
        } else {
           $quality = 5;
           print "MP3::Info didn't report the bitrate... weird. Corrupt MP3 file? Bug?\n";
           # User defined quality
           $quality = $userquality;
        }

Use the following structure:

        if (($userquality < -1) || ($userquality > 10)) {
            # Set quality adjacent to mp3 bitrate
            if($mp3bitrate ne "") {
                if($mp3bitrate > 256) {
                    $quality = 8;
                } elsif($mp3bitrate > 192) {
                    $quality = 7;
                } elsif($mp3bitrate > 128) {
                    $quality = 6;
                } else {
                    $quality = 5;
                }
            } else {
              $quality = 5;
              print "MP3::Info didn't report the bitrate... weird. Corrupt MP3 file? Bug?\n";
            }
        } else {
           # User defined quality
           $quality = $userquality;
        }

[Comment 1 Samuli Suominen (RETIRED) 2009-05-12 13:22:56 UTC]

Please provide a patch instead if you want this to go anywhere. Use the Create New Attachment and diff -u (man diff).

[Comment 2 Samuli Suominen (RETIRED) 2009-07-25 22:00:57 UTC]

Tried copying your suggested change with but always ended up with "Execution of /usr/bin/mp32ogg aborted due to compilation errors".

Closing. Reopen when you've got a patch to attach, thanks.