Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 24958 - Enhancement patch for X-Chat... Adds new numerics...
Summary: Enhancement patch for X-Chat... Adds new numerics...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Lowest minor (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-07-21 04:16 UTC by David Bauman
Modified: 2003-09-28 10:45 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Ebuild with new patch (xchat-2.0.3-r2.ebuild,1.77 KB, text/plain)
2003-07-21 04:18 UTC, David Bauman
Details
Ebuild with new patch (xchat-2.0.3-r2.ebuild,1.77 KB, text/plain)
2003-07-21 04:19 UTC, David Bauman
Details
Newer ebuild that adds another patch to fix a username bug (xchat-2.0.3-r2.ebuild,1.94 KB, text/plain)
2003-07-21 04:59 UTC, David Bauman
Details
Numerics patch against X-Chat 2.0.3-r1 (xchat-whois-undernet.patch,3.18 KB, patch)
2003-07-23 06:36 UTC, David Bauman
Details | Diff
Nickname behavior patch against X-Chat 2.0.3-r1 (xchat-2.0.3-text_word_check-chanmode.patch,1.00 KB, patch)
2003-07-23 06:38 UTC, David Bauman
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Bauman 2003-07-21 04:16:02 UTC
New patch for X-Chat, adding support for the following numerics: 330, 338 (Account 
information/real host/ip information on ircu-based IRC networks (QuakeNET, 
GamesNET, Undernet))
Comment 1 David Bauman 2003-07-21 04:18:50 UTC
Created attachment 14799 [details]
Ebuild with new patch

Ebuild making use of new xchat-undernet-whois.patch
Comment 2 David Bauman 2003-07-21 04:19:05 UTC
Created attachment 14800 [details]
Ebuild with new patch

Ebuild making use of new xchat-undernet-whois.patch
Comment 3 David Bauman 2003-07-21 04:59:39 UTC
Created attachment 14802 [details]
Newer ebuild that adds another patch to fix a username bug

This ebuild includes a patch to fix a bug with how X-Chat handles usernames;
usernames prefixed with an @ or + or % in /names weren't treated as usernames,
and so clicking on them wouldn't pop up the username menu as it would on users
with out any status in the channel. Some scripts prefix usernames with their
status in general conversation, thus making the menu practically useless from
outside the userlist box...
Comment 4 foser (RETIRED) gentoo-dev 2003-07-23 04:39:22 UTC
i'm not too eager to include patches not (going to be) supported by the package maintainers. Is there an xchat bug about this and is it in line to be included ?

What about the username bug ? Please explain why it is needed, what it fixes and we would want to add it.

Also attach small patches, so we can add them to the filesdir if needed. Getting them from some unreliable userdir is not a good idea.
Comment 5 David Bauman 2003-07-23 06:35:14 UTC
YEs, X-Chat bugs 774937 and 774958 (one for each patch)... what x-chat's 
maintainers decide to do with them I have no idea (they were submitted the same 
night as this ebuild and probably haven't even been looked at carefully yet (if at 
all)). 
 
The username bug patches X-Chat so that it recognizes usernames properly with 
status. For example, if you /names #channel then it will print a list of all the 
usernames... usernames prefixed with a status symbol (@, +, or %) were not treated 
as usernames- right clicking on them pulled up the main X-Chat menu, where as the 
username with out a status symbol pulled up the nickname popup menu. Some 
people also use a script that prefixes the usernames with their status symbol in the 
general chat area as well, and thus right clicking on those names anywhere except 
the userlist on the right is useless. 
Comment 6 David Bauman 2003-07-23 06:36:21 UTC
Created attachment 14917 [details, diff]
Numerics patch against X-Chat 2.0.3-r1

Here is the first patch requested...
Comment 7 David Bauman 2003-07-23 06:38:32 UTC
Created attachment 14918 [details, diff]
Nickname behavior patch against X-Chat 2.0.3-r1

The other patch for the nickname inconsistancy treatment bug
Comment 8 foser (RETIRED) gentoo-dev 2003-07-31 02:54:05 UTC
well, 2.0.4 soon to enter portage fixes one of these patches. The other one (the nick stuff), doesn't apply cleanly for me. Can you have a look at that ?

I havent looked at the code, but is it safe here to do word+1 (say you have 1 letter nicks) ?
Comment 9 foser (RETIRED) gentoo-dev 2003-08-10 17:35:14 UTC
reporter please respond
Comment 10 David Bauman 2003-08-10 19:20:11 UTC
Sorry, I just got back from being out of town. 
 
The numerics patch does not apply cleanly against 2.0.4 as it is included in 2.0.4 
by X-Chat's maintainers. 
Comment 11 foser (RETIRED) gentoo-dev 2003-08-11 02:44:02 UTC
the numerics patch i know and thats the one i mean in #8, it's about the other patch.
Comment 12 David Bauman 2003-08-12 01:51:47 UTC
After digging though some code, the nickname fix patch has also been applied to 
the 2.0.4 source tree. 
Comment 13 foser (RETIRED) gentoo-dev 2003-08-12 03:42:45 UTC
ok, it wasn't in the ChangeLog and i didn't check the code.

Thanks for your help, hope to apply things faster next time.
Comment 14 Alastair Tse (RETIRED) gentoo-dev 2003-09-28 10:45:17 UTC
reclosing