Bug 248917 – xen-tools: xendomains init script stop action fails when screen session cannot be found/shut down with SCREEN=yes

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Wolfram Schlich (RETIRED) 2008-11-26 17:00:56 UTC]

with SCREEN=yes, "/etc/init.d/xendomains stop" fails when it
cannot successfully shut down the screen session attached to
the automatically started domU consoles.
this can, for example, happen when root attached himself to
the screen session using "screen -DR" and more or less
accidentally closing it afterwards.

solution: check whether the xen screen session is running
at all by sending "sleep 0" first and if that exits with 0,
then send "quit", if not, eend 0 (see patch 1).

alternative solution: make "quit" be non-fatal in any case
(see patch 2).

[Comment 1 Wolfram Schlich (RETIRED) 2008-11-26 17:01:41 UTC]

Created attachment 173484 [details, diff]
xendomains patch 1

[Comment 2 Wolfram Schlich (RETIRED) 2008-11-26 17:02:13 UTC]

Created attachment 173485 [details, diff]
xendomains patch 2

[Comment 3 Wolfram Schlich (RETIRED) 2009-01-26 13:48:58 UTC]

ping

[Comment 4 Patrick Lauer 2009-06-27 07:43:43 UTC]

Just do it, Wolfram. Noone will be upset if you fix it.

[Comment 5 Wolfram Schlich (RETIRED) 2009-09-01 09:58:51 UTC]

In portage (3.4.1-r1).